You are viewing a plain text version of this content. The canonical link for it is here.

Posted to derby-dev@db.apache.org by "Lizx (Jira)" <ji...@apache.org> on 2021/12/12 05:35:00 UTC

[jira] [Created] (DERBY-7130) The code comments in "DataDictionaryImpl.java" require updates

Lizx created DERBY-7130:
---------------------------

             Summary: The code comments in "DataDictionaryImpl.java" require updates
                 Key: DERBY-7130
                 URL: https://issues.apache.org/jira/browse/DERBY-7130
             Project: Derby
          Issue Type: Bug
            Reporter: Lizx


A piece of comment in method "genColumnReferenceSQL" says "Column position is used to avoid the wrong column being selected problem (DERBY-1258) caused by the case insensitive JDBC rules for fetching a column by name." But this method never uses column position as a parameter. It makes me confused. Then I refer to the commit which fixed the issue DERBY-1258. In the commit, developer replace colName with colDesc.getPosition() to solve the problem. In recent source files, the modified lines are removed. So I wonder if the code commens require updates.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)