[GitHub] [inlong] EMsnap commented on a diff in pull request #7610: [INLONG-7609][Sort] Add audit for Kafka source connector

["EMsnap (via GitHub)" <gi...@apache.org>]

EMsnap commented on code in PR #7610:
URL: https://github.com/apache/inlong/pull/7610#discussion_r1136459489


##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/metric/MetricsCollector.java:
##########
@@ -15,10 +15,9 @@
  * limitations under the License.
  */
 
-package org.apache.inlong.sort.pulsar.withoutadmin;

Review Comment:
   the scope of sort-format-base in connector-base is provided



##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/metric/MetricsCollector.java:
##########
@@ -15,10 +15,9 @@
  * limitations under the License.
  */
 
-package org.apache.inlong.sort.pulsar.withoutadmin;

Review Comment:
   The compilation will fail since it depences on sort-format-base



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org