[jira] [Commented] (IGNITE-7931) Wrong arguments for `keys` in DataStreamerImpl

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-7931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16401789#comment-16401789 ] 

ASF GitHub Bot commented on IGNITE-7931:
----------------------------------------

GitHub user 1vanan opened a pull request:

    https://github.com/apache/ignite/pull/3646

    IGNITE-7931

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1vanan/ignite ignite-7931

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/3646.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3646
    
----
commit 93bd6973893c1e788ff1034980c0e0b8b1c4ef7c
Author: Fedotov <va...@...>
Date:   2018-03-16T11:45:55Z

    change arguments in keys variable

----


>  Wrong arguments for `keys` in DataStreamerImpl
> -----------------------------------------------
>
>                 Key: IGNITE-7931
>                 URL: https://issues.apache.org/jira/browse/IGNITE-7931
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Ivan Fedotov
>            Assignee: Ivan Fedotov
>            Priority: Trivial
>             Fix For: 2.5
>
>
> When creating
> {code:java|title=DataStreamerImpl.java}
> keys = new GridConcurrentHashSet<>(entries.size(), U.capacity(entries.size()), 1);{code}
> [1],[2] result of `U.capacity` is passed as `loadFactor` value. When loadFactor == U.capacity, initial size of table is 1. This leads to performance penalty due to rehashing of internal map.
> [1][https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/internal/processors/datastreamer/DataStreamerImpl.java#L633]
> [2][https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/internal/processors/datastreamer/DataStreamerImpl.java#L574]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)