You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joshua Cohen <jc...@apache.org> on 2015/08/26 22:03:33 UTC
Review Request 37809: Use a copy of the table config to avoid
contaminating pagination settings.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37809/
-----------------------------------------------------------
Review request for Aurora and David McLaughlin.
Repository: aurora
Description
-------
Use a copy of the table config to avoid contaminating pagination settings.
Diffs
-----
src/main/resources/scheduler/assets/js/services.js 085a3d9a290211e11ec88a678155e7881d4983dc
Diff: https://reviews.apache.org/r/37809/diff/
Testing
-------
Set page size to 2, verified that 3 active tasks were paginated but 2 completed tasks (for the same job) did not.
Thanks,
Joshua Cohen
Re: Review Request 37809: Use a copy of the table config to avoid
contaminating pagination settings.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37809/#review96585
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On Aug. 26, 2015, 8:03 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37809/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 8:03 p.m.)
>
>
> Review request for Aurora and David McLaughlin.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use a copy of the table config to avoid contaminating pagination settings.
>
>
> Diffs
> -----
>
> src/main/resources/scheduler/assets/js/services.js 085a3d9a290211e11ec88a678155e7881d4983dc
>
> Diff: https://reviews.apache.org/r/37809/diff/
>
>
> Testing
> -------
>
> Set page size to 2, verified that 3 active tasks were paginated but 2 completed tasks (for the same job) did not.
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 37809: Use a copy of the table config to avoid
contaminating pagination settings.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37809/#review96587
-----------------------------------------------------------
Master (3fdbc8c) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Aug. 26, 2015, 8:03 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37809/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 8:03 p.m.)
>
>
> Review request for Aurora and David McLaughlin.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use a copy of the table config to avoid contaminating pagination settings.
>
>
> Diffs
> -----
>
> src/main/resources/scheduler/assets/js/services.js 085a3d9a290211e11ec88a678155e7881d4983dc
>
> Diff: https://reviews.apache.org/r/37809/diff/
>
>
> Testing
> -------
>
> Set page size to 2, verified that 3 active tasks were paginated but 2 completed tasks (for the same job) did not.
>
>
> Thanks,
>
> Joshua Cohen
>
>