You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2018/08/08 15:29:28 UTC
[Impala-ASF-CR] Switch a couple of lists to deques in AnalyticEvalNode
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11159
Change subject: Switch a couple of lists to deques in AnalyticEvalNode
......................................................................
Switch a couple of lists to deques in AnalyticEvalNode
I noticed this inefficiency while looking at this code.
std::deque generally offers better performance because it does fewer
memory allocations and has better memory locality. The main advantages
of std::list are O(1) insert/delete in the middle of the list and
stable iterators that remain valid through list modifications,
but neither property is useful for these result_tuples_ and
window_tuples_ because we only append at the back, remove from the front
and iterate over the whole list at once.
Change-Id: Iaa716dcf241a0a9e4f5221e5cf7a1596c75aecc0
---
M be/src/exec/analytic-eval-node.cc
M be/src/exec/analytic-eval-node.h
2 files changed, 14 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/11159/1
--
To view, visit http://gerrit.cloudera.org:8080/11159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa716dcf241a0a9e4f5221e5cf7a1596c75aecc0
Gerrit-Change-Number: 11159
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Switch a couple of lists to deques in AnalyticEvalNode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11159 )
Change subject: Switch a couple of lists to deques in AnalyticEvalNode
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/236/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa716dcf241a0a9e4f5221e5cf7a1596c75aecc0
Gerrit-Change-Number: 11159
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Aug 2018 16:03:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Switch a couple of lists to deques in AnalyticEvalNode
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11159 )
Change subject: Switch a couple of lists to deques in AnalyticEvalNode
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa716dcf241a0a9e4f5221e5cf7a1596c75aecc0
Gerrit-Change-Number: 11159
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 08 Aug 2018 18:49:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Switch a couple of lists to deques in AnalyticEvalNode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11159 )
Change subject: Switch a couple of lists to deques in AnalyticEvalNode
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa716dcf241a0a9e4f5221e5cf7a1596c75aecc0
Gerrit-Change-Number: 11159
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 08 Aug 2018 22:03:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Switch a couple of lists to deques in AnalyticEvalNode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11159 )
Change subject: Switch a couple of lists to deques in AnalyticEvalNode
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2954/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa716dcf241a0a9e4f5221e5cf7a1596c75aecc0
Gerrit-Change-Number: 11159
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 08 Aug 2018 18:49:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Switch a couple of lists to deques in AnalyticEvalNode
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11159 )
Change subject: Switch a couple of lists to deques in AnalyticEvalNode
......................................................................
Patch Set 1: Code-Review+2
Reminds me of ed0b1e94d30d63d7f017ec830a8df7c3a1820c15 which we fixed 3 years ago... std::list is the gift that keeps on giving!
--
To view, visit http://gerrit.cloudera.org:8080/11159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa716dcf241a0a9e4f5221e5cf7a1596c75aecc0
Gerrit-Change-Number: 11159
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 08 Aug 2018 18:33:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Switch a couple of lists to deques in AnalyticEvalNode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11159 )
Change subject: Switch a couple of lists to deques in AnalyticEvalNode
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/251/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa716dcf241a0a9e4f5221e5cf7a1596c75aecc0
Gerrit-Change-Number: 11159
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 08 Aug 2018 19:14:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Switch a couple of lists to deques in AnalyticEvalNode
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11159 )
Change subject: Switch a couple of lists to deques in AnalyticEvalNode
......................................................................
Patch Set 1:
Yeah I remember that one - got burned another time too with http://gerrit.cloudera.org:8080/7382
--
To view, visit http://gerrit.cloudera.org:8080/11159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa716dcf241a0a9e4f5221e5cf7a1596c75aecc0
Gerrit-Change-Number: 11159
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 08 Aug 2018 18:47:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Switch a couple of lists to deques in AnalyticEvalNode
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Todd Lipcon, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11159
to look at the new patch set (#2).
Change subject: Switch a couple of lists to deques in AnalyticEvalNode
......................................................................
Switch a couple of lists to deques in AnalyticEvalNode
I noticed this inefficiency while looking at this code.
std::deque generally offers better performance because it does fewer
memory allocations and has better memory locality. The main advantages
of std::list are O(1) insert/delete in the middle of the list and
stable iterators that remain valid through list modifications,
but neither property is useful for these result_tuples_ and
window_tuples_ because we only append at the back, remove from the front
and iterate over the whole list at once.
Change-Id: Iaa716dcf241a0a9e4f5221e5cf7a1596c75aecc0
---
M be/src/exec/analytic-eval-node.cc
M be/src/exec/analytic-eval-node.h
2 files changed, 13 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/11159/2
--
To view, visit http://gerrit.cloudera.org:8080/11159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaa716dcf241a0a9e4f5221e5cf7a1596c75aecc0
Gerrit-Change-Number: 11159
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[Impala-ASF-CR] Switch a couple of lists to deques in AnalyticEvalNode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11159 )
Change subject: Switch a couple of lists to deques in AnalyticEvalNode
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa716dcf241a0a9e4f5221e5cf7a1596c75aecc0
Gerrit-Change-Number: 11159
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 08 Aug 2018 18:49:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Switch a couple of lists to deques in AnalyticEvalNode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11159 )
Change subject: Switch a couple of lists to deques in AnalyticEvalNode
......................................................................
Switch a couple of lists to deques in AnalyticEvalNode
I noticed this inefficiency while looking at this code.
std::deque generally offers better performance because it does fewer
memory allocations and has better memory locality. The main advantages
of std::list are O(1) insert/delete in the middle of the list and
stable iterators that remain valid through list modifications,
but neither property is useful for these result_tuples_ and
window_tuples_ because we only append at the back, remove from the front
and iterate over the whole list at once.
Change-Id: Iaa716dcf241a0a9e4f5221e5cf7a1596c75aecc0
Reviewed-on: http://gerrit.cloudera.org:8080/11159
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/analytic-eval-node.cc
M be/src/exec/analytic-eval-node.h
2 files changed, 13 insertions(+), 14 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/11159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa716dcf241a0a9e4f5221e5cf7a1596c75aecc0
Gerrit-Change-Number: 11159
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>