Re: swig: srcdir vs. blddir

[Julian Foad <ju...@btopenworld.com>]

David James wrote:
> 
> [[[
> Always generate SWIG/C files in the source directory.

In the log message, can you try to include a few words to indicate why the 
change is being made, so that somebody who might contest it later on can judge 
whether it was done for a good reason and/or is still appropriate at that 
future time.  If it can't be summarised well in a sentence or two, include a 
link to the email thread or issue.  This applies to any commit the reason for 
which is not totally self-evident.  Thanks.

> * build/generator/gen_make.py
>   (write): Generate SWIG/C files in source directory. Don't copy SWIG/C
>   files from the source directory to the build directory.
[...]

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: swig: srcdir vs. blddir

[David James <ja...@cs.toronto.edu>]

On 11/23/05, Julian Foad <ju...@btopenworld.com> wrote:
> David James wrote:
> >
> > [[[
> > Always generate SWIG/C files in the source directory.
>
> In the log message, can you try to include a few words to indicate why the
> change is being made, so that somebody who might contest it later on can judge
> whether it was done for a good reason and/or is still appropriate at that
> future time.  If it can't be summarised well in a sentence or two, include a
> link to the email thread or issue.  This applies to any commit the reason for
> which is not totally self-evident.  Thanks.

Good idea! I've added a summary to my log message, and also a link to
the thread. Here's my new log message:

[[[
Always generate SWIG/C files and SWIG headers in the source directory.

(Now that the SWIG generated files are bundled in source tarballs, it makes
 sense to treat them as "source directory" files. This change greatly
 simplifies our SWIG build system, because we don't have to worry about
 copying generated SWIG files from the source directory to the build directory
 any more.)


* Makefile.in
 (SWIG_PL_SRC_DIR): Add variable.

 (EXTRACLEAN_SWIG_HEADERS, EXTRACLEAN_SWIG_PL, EXTRACLEAN_SWIG_PY,
  EXTRACLEAN_SWIG_RB): Clean SWIG files from the source directory.

 (copy-swig-py): Copy Python files directly from the source directory to
 the libsvn directory.


* build/generator/gen_base.py
 (TargetSWIG.add_dependencies): Read and write generated SWIG/C files in
 the source directory.


* build/generator/gen_make.py
 (write): Generate SWIG headers and SWIG/C files in source directory. Don't
 copy SWIG/C files from the source directory to the build directory.


Suggested by: epg
Thread: http://svn.haxx.se/dev/archive-2005-11/1207.shtml
]]]

I've committed this patch with several improvements in r17497.

Hope this helps!

David


--
David James -- http://www.cs.toronto.edu/~james