[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8514: [fix] cluster_name = cluster_name, not cluster_id

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #8514: [fix] cluster_name = cluster_name, not cluster_id
URL: https://github.com/apache/incubator-superset/pull/8514#discussion_r343773507
 
 

 ##########
 File path: superset/connectors/druid/models.py
 ##########
 @@ -1612,7 +1612,7 @@ def query_datasources_by_name(
     ) -> List["DruidDatasource"]:
         return (
             session.query(cls)
-            .filter_by(cluster_name=database.id)
+            .filter_by(cluster_name=database.database_name)
 
 Review comment:
   Maybe @mistercrunch could chime in here? This code is pretty old

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org