[GitHub] [beam] lukecwik commented on a change in pull request #11546: [BEAM-9832] Ensuring tags are not added to ProcessBundleDescriptors o…

[GitBox <gi...@apache.org>]

lukecwik commented on a change in pull request #11546:
URL: https://github.com/apache/beam/pull/11546#discussion_r416274806



##########
File path: sdks/python/apache_beam/runners/worker/operations.py
##########
@@ -724,6 +724,8 @@ def pcollection_count_monitoring_infos(self, tag_to_pcollection_id):
 
     if self.tagged_receivers:
       for tag, receiver in self.tagged_receivers.items():
+        if str(tag) not in tag_to_pcollection_id:

Review comment:
       It would be weird that accessing the dict adds the entry in this case but if this is the solution then it would be better we created a copy of the dict we pass from here:
   https://github.com/apache/beam/blob/2434d496571aa46efda1a18d9ccc319815b712f8/sdks/python/apache_beam/runners/worker/bundle_processor.py#L1038




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org