You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/04/04 04:12:37 UTC

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4073: Move Parquet related classes to the new package

snleee commented on a change in pull request #4073: Move Parquet related classes to the new package
URL: https://github.com/apache/incubator-pinot/pull/4073#discussion_r272011649
 
 

 ##########
 File path: pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/mapper/SegmentCreationMapper.java
 ##########
 @@ -101,8 +101,7 @@ public void setup(Context context)
     if (readerConfigFile != null) {
       _readerConfigFile = new Path(readerConfigFile);
     }
-
-    _recordReaderPath = _jobConf.get(JobConfigConstants.RECORD_READER_PATH, null);
+    _recordReaderPath = _jobConf.get(JobConfigConstants.RECORD_READER_PATH);
 
 Review comment:
   `RECORD_READER_CLASS_NAME` seems to be more correct name... But, I guess that we are already using this config?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org