[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11705: Add more test for broker jersey bounded thread pool

["Jackie-Jiang (via GitHub)" <gi...@apache.org>]

Jackie-Jiang commented on code in PR #11705:
URL: https://github.com/apache/pinot/pull/11705#discussion_r1340700894


##########
pinot-broker/src/test/java/org/apache/pinot/broker/broker/BrokerManagedAsyncExecutorProviderTest.java:
##########
@@ -92,6 +94,23 @@ public void testGet()
 
     BlockingQueue<Runnable> blockingQueue = threadPoolExecutor.getQueue();
     assertNotNull(blockingQueue);
+    assertTrue(blockingQueue instanceof LinkedBlockingQueue);
+    assertEquals(0, blockingQueue.size());

Review Comment:
   Not introduced in this PR, but can you reverse the arguments? The first argument should be the actual value, and second one is the expected value. I'd suggest also fixing the misuse in other places



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org