[PATCH 13453] Bug 24331: SSLPassPhraseDialog exec: always default port in argv

[Leif W <wa...@usa.net>]

Summary: SSLPassPhraseDialog exec: always default port in argv

BUG 24331
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24331

PATCH 13453
http://nagoya.apache.org/bugzilla/showattachment.cgi?attach_id=13453

The bug still exists in 2.0.52.  I first noticed this bug in 2.0.49,
tested with 2.0.48 and it was there as well, and the original reporter
patched against 2.0.47.  I have not tested how far back it goes.

I simplified the original patch.  Now only 3 lines are changed: 1
modified, 2 added.  Now it first checks s->addrs->host_port and then
s->port.  s->addrs is a list, but the patch only looks at the first
host_port.  I don't know if or when this might be a problem.  But the
results for me are more correct with the patch.

It appears to work fine, but is not heavily tested, so I seek tests and
comments.  This is an old bug which could seriously limit multi-port
(non-443) SSL configurations.  This is simple to fix with no side
effects, so I'd like to see testing and feedback and an eventual CVS
commit.  :-)

SSLPassPhraseDialog exec:/path/to/pass_phrase_script
# which logs it's actions, as shown below args ( host:port, method )

WRONG: before patch, port is shown as 443

[2004-11-13@11:59:39]        uid=0(root) gid=0(root) groups=0(root)
sent password        args ( some-host:443, RSA )

RIGHT: after patch, real port of 4301 is correctly shown

[2004-11-14@13:25:44]        uid=0(root) gid=0(root) groups=0(root)
sent password        args ( some-host:4301, RSA )