You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2026/04/11 13:57:24 UTC
[Impala-ASF-CR] IMPALA-14885: Remove async rpc pool which has no usages
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24182
Change subject: IMPALA-14885: Remove async_rpc_pool_ which has no usages
......................................................................
IMPALA-14885: Remove async_rpc_pool_ which has no usages
async_rpc_pool_ used to be the thread pool for sending Thrift
UpdateFilter RPCs. After IMPALA-7984 ports UpdateFilter to KRPC, this
thread pool has no usages and should be removed. This also saves 8
threads that are never used.
Change-Id: I7b1f9bccc34f4b00f7914c93adc986dc448501c0
---
M be/src/runtime/exec-env.cc
M be/src/runtime/exec-env.h
2 files changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/24182/1
--
To view, visit http://gerrit.cloudera.org:8080/24182
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7b1f9bccc34f4b00f7914c93adc986dc448501c0
Gerrit-Change-Number: 24182
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-14885: Remove async rpc pool which has no usages
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24182 )
Change subject: IMPALA-14885: Remove async_rpc_pool_ which has no usages
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/24182
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b1f9bccc34f4b00f7914c93adc986dc448501c0
Gerrit-Change-Number: 24182
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Sat, 11 Apr 2026 23:46:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14885: Remove async rpc pool which has no usages
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24182 )
Change subject: IMPALA-14885: Remove async_rpc_pool_ which has no usages
......................................................................
IMPALA-14885: Remove async_rpc_pool_ which has no usages
async_rpc_pool_ used to be the thread pool for sending Thrift
UpdateFilter RPCs. After IMPALA-7984 ports UpdateFilter to KRPC, this
thread pool has no usages and should be removed. This also saves 8
threads that are never used.
Change-Id: I7b1f9bccc34f4b00f7914c93adc986dc448501c0
Reviewed-on: http://gerrit.cloudera.org:8080/24182
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/runtime/exec-env.cc
M be/src/runtime/exec-env.h
2 files changed, 0 insertions(+), 4 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/24182
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7b1f9bccc34f4b00f7914c93adc986dc448501c0
Gerrit-Change-Number: 24182
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-14885: Remove async rpc pool which has no usages
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/24182 )
Change subject: IMPALA-14885: Remove async_rpc_pool_ which has no usages
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/24182
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b1f9bccc34f4b00f7914c93adc986dc448501c0
Gerrit-Change-Number: 24182
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Sat, 11 Apr 2026 19:14:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14885: Remove async rpc pool which has no usages
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24182 )
Change subject: IMPALA-14885: Remove async_rpc_pool_ which has no usages
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13314/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/24182
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b1f9bccc34f4b00f7914c93adc986dc448501c0
Gerrit-Change-Number: 24182
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Sat, 11 Apr 2026 19:15:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14885: Remove async rpc pool which has no usages
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24182 )
Change subject: IMPALA-14885: Remove async_rpc_pool_ which has no usages
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/22111/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24182
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b1f9bccc34f4b00f7914c93adc986dc448501c0
Gerrit-Change-Number: 24182
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sat, 11 Apr 2026 14:20:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14885: Remove async rpc pool which has no usages
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24182 )
Change subject: IMPALA-14885: Remove async_rpc_pool_ which has no usages
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/24182
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b1f9bccc34f4b00f7914c93adc986dc448501c0
Gerrit-Change-Number: 24182
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Sat, 11 Apr 2026 19:15:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14885: Remove async rpc pool which has no usages
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24182 )
Change subject: IMPALA-14885: Remove async_rpc_pool_ which has no usages
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/24182
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b1f9bccc34f4b00f7914c93adc986dc448501c0
Gerrit-Change-Number: 24182
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sat, 11 Apr 2026 17:32:10 +0000
Gerrit-HasComments: No