[GitHub] [cassandra] maedhroz commented on a change in pull request #1182: Cassandra 16905

[GitBox <gi...@apache.org>]

maedhroz commented on a change in pull request #1182:
URL: https://github.com/apache/cassandra/pull/1182#discussion_r706470092



##########
File path: src/java/org/apache/cassandra/db/marshal/CollectionType.java
##########
@@ -199,6 +199,15 @@ public boolean isValueCompatibleWithInternal(AbstractType<?> previous)
         return isValueCompatibleWithFrozen(tprev);
     }
 
+    @Override
+    public boolean isSerializationCompatibleWith(AbstractType<?> previous)
+    {
+        if (!isValueCompatibleWith(previous))
+            return false;
+
+        return valueComparator().isSerializationCompatibleWith(((CollectionType)previous).valueComparator());

Review comment:
       ```suggestion
           return valueComparator().isSerializationCompatibleWith(((CollectionType<?>)previous).valueComparator());
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org