You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/25 14:28:23 UTC

[GitHub] [arrow-datafusion] liukun4515 commented on a diff in pull request #4373: HashJoin should return Err when the right side input stream produce Err, add more join UTs to cover different join types

liukun4515 commented on code in PR #4373:
URL: https://github.com/apache/arrow-datafusion/pull/4373#discussion_r1032505773


##########
datafusion/core/src/physical_plan/joins/hash_join.rs:
##########
@@ -1554,7 +1554,8 @@ impl HashJoinStream {
                     }
                     Some(result.map(|x| x.0))
                 }
-                other => {
+                Some(err) => Some(err),

Review Comment:
   👍 this is also found in the refactor pr https://github.com/apache/arrow-datafusion/pull/4377/files#



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org