You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Andres de la Peña (Jira)" <ji...@apache.org> on 2022/01/12 13:34:00 UTC
[jira] [Comment Edited] (CASSANDRA-17243) Fix BYTES_PER_MEGABIT in StreamManager
[ https://issues.apache.org/jira/browse/CASSANDRA-17243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474522#comment-17474522 ]
Andres de la Peña edited comment on CASSANDRA-17243 at 1/12/22, 1:33 PM:
-------------------------------------------------------------------------
Very good catch. Indeed the mistake of confusing megabits with mebibits was originally introduced by CASSANDRA-5286, back in 2.0, and it has been overlooked by multiple fixes around that calculation.
The straightforward fix is simply the one mentioned by [~e.dimitrova]:
||PR||CI||
|[3.0|https://github.com/apache/cassandra/pull/1399]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1236/workflows/e3c3a592-4be7-4bab-8ced-ec6719e78a18]|
|[3.11|https://github.com/apache/cassandra/pull/1400]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1235/workflows/679af579-50d6-46b5-a5cb-9bf4b3986cc6]|
|[4.0|https://github.com/apache/cassandra/pull/1401]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1238/workflows/c8981fa3-5770-4970-beee-1bc44f3b04b8] [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1238/workflows/27fbf649-60d5-4d8f-b6bf-0a0055fe8917]|
|[trunk|https://github.com/apache/cassandra/pull/1402]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1237/workflows/0805970f-2358-40f9-87c7-ac429c979c08] [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1237/workflows/91b1bec3-8bac-4771-9597-64546d7a6100]|
The CI runs above contain some repeated runs of {{{}StreamManagerTest{}}}. Any test is going to be based on the definition of a megabit, so I don't know if we should add anything there.
was (Author: adelapena):
Very good catch. Indeed the mistake of confusing megabits with mebibits was originally introduced by CASSANDRA-5286, back in 2.0, and it has been overlooked by multiple fixes around that calculation.
The straightforward fix is simply the one mentioned by [~e.dimitrova]:
||PR||CI||
|[3.0|https://github.com/apache/cassandra/pull/1399]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1236/workflows/e3c3a592-4be7-4bab-8ced-ec6719e78a18]|
|[3.11|https://github.com/apache/cassandra/pull/1400]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1235/workflows/679af579-50d6-46b5-a5cb-9bf4b3986cc6]|
|[4.0|https://github.com/apache/cassandra/pull/1401]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1238/workflows/c8981fa3-5770-4970-beee-1bc44f3b04b8] [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1238/workflows/27fbf649-60d5-4d8f-b6bf-0a0055fe8917]|
|[trunk|https://github.com/apache/cassandra/pull/1402]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1237/workflows/0805970f-2358-40f9-87c7-ac429c979c08] [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1237/workflows/91b1bec3-8bac-4771-9597-64546d7a6100]|
The CI runs above contain some repeated runs of {{{}StreamManagerTest{}}}.
> Fix BYTES_PER_MEGABIT in StreamManager
> --------------------------------------
>
> Key: CASSANDRA-17243
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17243
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Streaming
> Reporter: Ekaterina Dimitrova
> Assignee: Andres de la Peña
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> While working on CASSANDRA-15234 I noticed BYTES_PER_MEGABIT constant in the
> {code:java}
> StreamManager
> {code}
> class. It was introduced in CASSANDRA-16959.
> The current formula converts actually bytes to mebibits.
> The change needed for 3.0, 3.11 and 4.0(I am currently changing rate parameters to be in MiB/s for trunk as part of CASSANDRA-15234):
> {code:java}
> public static final double BYTES_PER_MEGABIT = (1000 * 1000) / 8; // from bits
> {code}
> CC [~adelapena]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org