You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "celeste-zeng (via GitHub)" <gi...@apache.org> on 2023/08/12 00:32:19 UTC

[GitHub] [beam] celeste-zeng opened a new pull request, #27982: Add ARM test suite trigger commands to mass comment script

celeste-zeng opened a new pull request, #27982:
URL: https://github.com/apache/beam/pull/27982

   - Add new trigger phrases for all post commit ARM test suites.
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on pull request #27982: Add ARM test suite trigger commands to mass comment script

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #27982:
URL: https://github.com/apache/beam/pull/27982#issuecomment-1677261417

   > @damccorm should we rename that file to smth like test_trigger_commands.txt or there is some advantage to split Jenkins and GH actions trigger commands in separate files?
   
   I think splitting into separate files makes sense. Jenkins triggers can be programatically determined (and we do that to update them as part of our release process) so having a distinct file for them makes management easy


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] celeste-zeng commented on a diff in pull request #27982: Add ARM test suite trigger commands to mass comment script

Posted by "celeste-zeng (via GitHub)" <gi...@apache.org>.
celeste-zeng commented on code in PR #27982:
URL: https://github.com/apache/beam/pull/27982#discussion_r1312016045


##########
release/src/main/scripts/mass_comment.py:
##########
@@ -123,8 +123,19 @@ def getRemainingComments(accessToken, pr, initialComments):
         and 'Sickbay' not in comment[1]:
       print(comment)
       remainingComments.append(comment)
+      arm_comments = getARMTestTriggerCommands();
+      remainingComments.append(arm_comments)
   return remainingComments
 
+def getARMTestTriggerCommands():
+  '''
+  Returns all trigger commands that will start PostCommit ARM Github Actions test suites.
+  '''
+  arm_trigger_commands = []

Review Comment:
   Or should I just create a github_actions_jobs.txt now instead and move all the trigger commands there? Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] tvalentyn commented on pull request #27982: Add ARM test suite trigger commands to mass comment script

Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #27982:
URL: https://github.com/apache/beam/pull/27982#issuecomment-1675573626

   i think we should add commands into a text file for consistency and simplicity; there is jenkins_jobs.txt. @damccorm should we rename that or there is some advantage to split Jenkins and GH actions trigger commands in separate files?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on a diff in pull request #27982: Add ARM test suite trigger commands to mass comment script

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #27982:
URL: https://github.com/apache/beam/pull/27982#discussion_r1312203697


##########
release/src/main/scripts/mass_comment.py:
##########
@@ -123,8 +123,19 @@ def getRemainingComments(accessToken, pr, initialComments):
         and 'Sickbay' not in comment[1]:
       print(comment)
       remainingComments.append(comment)
+      arm_comments = getARMTestTriggerCommands();
+      remainingComments.append(arm_comments)
   return remainingComments
 
+def getARMTestTriggerCommands():
+  '''
+  Returns all trigger commands that will start PostCommit ARM Github Actions test suites.
+  '''
+  arm_trigger_commands = []

Review Comment:
   Yeah, we should do that as well



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on a diff in pull request #27982: Add ARM test suite trigger commands to mass comment script

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #27982:
URL: https://github.com/apache/beam/pull/27982#discussion_r1312197150


##########
release/src/main/scripts/mass_comment.py:
##########
@@ -123,8 +123,19 @@ def getRemainingComments(accessToken, pr, initialComments):
         and 'Sickbay' not in comment[1]:
       print(comment)
       remainingComments.append(comment)
+      arm_comments = getARMTestTriggerCommands();
+      remainingComments.append(arm_comments)
   return remainingComments
 
+def getARMTestTriggerCommands():
+  '''
+  Returns all trigger commands that will start PostCommit ARM Github Actions test suites.
+  '''
+  arm_trigger_commands = []

Review Comment:
   I think leaving it is fine for now (with the comment added). Solving trigger commands for actions is an open question that will need to be solved generally soon anyways



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] celeste-zeng commented on a diff in pull request #27982: Add ARM test suite trigger commands to mass comment script

Posted by "celeste-zeng (via GitHub)" <gi...@apache.org>.
celeste-zeng commented on code in PR #27982:
URL: https://github.com/apache/beam/pull/27982#discussion_r1312199288


##########
release/src/main/scripts/mass_comment.py:
##########
@@ -123,8 +123,19 @@ def getRemainingComments(accessToken, pr, initialComments):
         and 'Sickbay' not in comment[1]:
       print(comment)
       remainingComments.append(comment)
+      arm_comments = getARMTestTriggerCommands();
+      remainingComments.append(arm_comments)
   return remainingComments
 
+def getARMTestTriggerCommands():
+  '''
+  Returns all trigger commands that will start PostCommit ARM Github Actions test suites.
+  '''
+  arm_trigger_commands = []

Review Comment:
   I see, thanks! But since there are multiple versions of Java and Python, I also need to adjust the trigger command to "Run Java_Examples_Dataflow_ARM PostCommit 11" "Run Python ValidatesContainer Dataflow ARM 3.8"? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #27982: Add ARM test suite trigger commands to mass comment script

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27982:
URL: https://github.com/apache/beam/pull/27982#issuecomment-1701567016

   Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @Abacn for label build.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] tvalentyn commented on a diff in pull request #27982: Add ARM test suite trigger commands to mass comment script

Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #27982:
URL: https://github.com/apache/beam/pull/27982#discussion_r1313566768


##########
release/src/main/scripts/mass_comment.py:
##########
@@ -125,6 +125,21 @@ def getRemainingComments(accessToken, pr, initialComments):
       remainingComments.append(comment)
   return remainingComments
 
+def getGithubActionsTriggerCommands(dirname):
+  '''
+  Returns all trigger commands that will start PostCommit Dataflow ARM Github Actions test suites.
+  TODO: Should add all github-actions trigger commands to github_actions_jobs.txt

Review Comment:
   Does this script not handle GHA triggers? Not sure I understand this TODO.



##########
release/src/main/scripts/mass_comment.py:
##########
@@ -125,6 +125,21 @@ def getRemainingComments(accessToken, pr, initialComments):
       remainingComments.append(comment)
   return remainingComments
 
+def getGithubActionsTriggerCommands(dirname):
+  '''
+  Returns all trigger commands that will start PostCommit Dataflow ARM Github Actions test suites.
+  TODO: Should add all github-actions trigger commands to github_actions_jobs.txt

Review Comment:
   Does this script not handle GHA triggers? Not sure I understand this TODO.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] commented on pull request #27982: Add ARM test suite trigger commands to mass comment script

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #27982:
URL: https://github.com/apache/beam/pull/27982#issuecomment-1675575443

   ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/27982?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#27982](https://app.codecov.io/gh/apache/beam/pull/27982?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (95bac96) into [master](https://app.codecov.io/gh/apache/beam/commit/3f09b0f11a9b8f13562f6624d34270f6daddbd03?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3f09b0f) will **decrease** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #27982      +/-   ##
   ==========================================
   - Coverage   72.31%   72.31%   -0.01%     
   ==========================================
     Files         678      678              
     Lines       99726    99726              
   ==========================================
   - Hits        72119    72117       -2     
   - Misses      26047    26049       +2     
     Partials     1560     1560              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | python | `82.85% <ø> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   [see 3 files with indirect coverage changes](https://app.codecov.io/gh/apache/beam/pull/27982/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] kennknowles commented on pull request #27982: Add ARM test suite trigger commands to mass comment script

Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #27982:
URL: https://github.com/apache/beam/pull/27982#issuecomment-1736016928

   Here is the console output for `mass_comment.py` which will give the hint needed to fix this:
   
   ```
   ...
   ('Run PythonFormatter PreCommit', 'beam_PreCommit_PythonFormatter_Phrase')
   ('Run PythonLint PreCommit', 'beam_PreCommit_PythonLint_Phrase')
   ('Run RAT PreCommit', 'beam_PreCommit_RAT_Phrase')
   ('Run Spotless PreCommit', 'beam_PreCommit_Spotless_Phrase')
   ('Run Typescript PreCommit', 'beam_PreCommit_Typescript_Phrase')
   ('Run Whitespace PreCommit', 'beam_PreCommit_Whitespace_Phrase')
   Run Go PostCommit Dataflow ARM
   Run Java_Examples_Dataflow_ARM PostCommit 8
   Run Java_Examples_Dataflow_ARM PostCommit 11
   Run Java_Examples_Dataflow_ARM PostCommit 17
   ...
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on a diff in pull request #27982: Add ARM test suite trigger commands to mass comment script

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #27982:
URL: https://github.com/apache/beam/pull/27982#discussion_r1311968949


##########
release/src/main/scripts/mass_comment.py:
##########
@@ -123,8 +123,19 @@ def getRemainingComments(accessToken, pr, initialComments):
         and 'Sickbay' not in comment[1]:
       print(comment)
       remainingComments.append(comment)
+      arm_comments = getARMTestTriggerCommands();
+      remainingComments.append(arm_comments)
   return remainingComments
 
+def getARMTestTriggerCommands():
+  '''
+  Returns all trigger commands that will start PostCommit ARM Github Actions test suites.
+  '''
+  arm_trigger_commands = []

Review Comment:
   Could you also add a comment along the lines of: remove this special case once this script can handle GitHub Actions triggers



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #27982: Add ARM test suite trigger commands to mass comment script

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #27982:
URL: https://github.com/apache/beam/pull/27982#issuecomment-1736024542

   I see the issue, going to fix along with #28665


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] kennknowles commented on pull request #27982: Add ARM test suite trigger commands to mass comment script

Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #27982:
URL: https://github.com/apache/beam/pull/27982#issuecomment-1736016164

   https://github.com/apache/beam/pull/28663#issuecomment-1736001629 :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] tvalentyn merged pull request #27982: Add ARM test suite trigger commands to mass comment script

Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn merged PR #27982:
URL: https://github.com/apache/beam/pull/27982


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] celeste-zeng commented on pull request #27982: Add ARM test suite trigger commands to mass comment script

Posted by "celeste-zeng (via GitHub)" <gi...@apache.org>.
celeste-zeng commented on PR #27982:
URL: https://github.com/apache/beam/pull/27982#issuecomment-1679758434

   Run Go PostCommit Dataflow ARM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #27982: Add ARM test suite trigger commands to mass comment script

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27982:
URL: https://github.com/apache/beam/pull/27982#issuecomment-1675607893

   Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] celeste-zeng commented on pull request #27982: Add ARM test suite trigger commands to mass comment script

Posted by "celeste-zeng (via GitHub)" <gi...@apache.org>.
celeste-zeng commented on PR #27982:
URL: https://github.com/apache/beam/pull/27982#issuecomment-1701878339

   Run Go PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org