You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2022/03/01 02:15:07 UTC

[GitHub] [sling-org-apache-sling-engine] janaki-r-bhagwath opened a new pull request #22: SLING-7492 Lots of logs on missing SlingRequestProgressTracker

janaki-r-bhagwath opened a new pull request #22:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/22


   - log level changed from warn to debug
   - Minor fixes REQUEST_MAX_CALL_OVERRIDE declared as final
   - ArrayList changed to List
   
   Resolves: SLING-7492


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-engine] sonarcloud[bot] commented on pull request #22: SLING-7492 Lots of logs on missing SlingRequestProgressTracker

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #22:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/22#issuecomment-1054915087


   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=22&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=22&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=22&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=22&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=22&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=22&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine&pullRequest=22&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine&pullRequest=22&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine&pullRequest=22&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=22&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=22&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=22&resolved=false&types=CODE_SMELL)
   
   [![100.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/100-16px.png '100.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=22&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=22&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=22&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=22&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-engine] janaki-r-bhagwath closed pull request #22: SLING-7492 Lots of logs on missing SlingRequestProgressTracker

Posted by GitBox <gi...@apache.org>.
janaki-r-bhagwath closed pull request #22:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/22


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-engine] janaki-r-bhagwath edited a comment on pull request #22: SLING-7492 Lots of logs on missing SlingRequestProgressTracker

Posted by GitBox <gi...@apache.org>.
janaki-r-bhagwath edited a comment on pull request #22:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/22#issuecomment-1068317146


   Closing this - as https://github.com/apache/sling-org-apache-sling-engine/commit/529802e2d538111336c60d98b35d16f2b9b3e51f would resolve the issue. Consumers can create valid requests with either SlingRequestBuilder or custom implementation of RequestProgressTracker after this change.
   Thank you very much @cziegeler 
   
   cc: @rombert 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-engine] rombert commented on pull request #22: SLING-7492 Lots of logs on missing SlingRequestProgressTracker

Posted by GitBox <gi...@apache.org>.
rombert commented on pull request #22:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/22#issuecomment-1057005918


   > @rombert , Yes, the change is just downgrading the log level.
   
   Which is why I'm asking whether you have considered simply silencing that logger in your local configuration. We need to understand why the warning happens and whether it's safe to do so before simply downgrading it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-engine] janaki-r-bhagwath commented on pull request #22: SLING-7492 Lots of logs on missing SlingRequestProgressTracker

Posted by GitBox <gi...@apache.org>.
janaki-r-bhagwath commented on pull request #22:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/22#issuecomment-1055804194


   @rombert , Yes, the change is just downgrading the log level. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-engine] rombert commented on pull request #22: SLING-7492 Lots of logs on missing SlingRequestProgressTracker

Posted by GitBox <gi...@apache.org>.
rombert commented on pull request #22:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/22#issuecomment-1055595193


   Thanks for the PR @janaki-r-bhagwath . I think this is simply downgrading a warn to a debug, right? I am not sure if that is the proper solution for this ticket.
   
   @bdelacretaz has originally introduced this warning in https://github.com/apache/sling-org-apache-sling-engine/commit/f26e1bc68824f1741b0341f38280377a0c657104, perhaps he can comment.
   
   In the meantime, I wonder whether a proper fix for you would be setting the respective log level to ERROR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-engine] janaki-r-bhagwath commented on pull request #22: SLING-7492 Lots of logs on missing SlingRequestProgressTracker

Posted by GitBox <gi...@apache.org>.
janaki-r-bhagwath commented on pull request #22:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/22#issuecomment-1068317146


   Closing this - as https://github.com/apache/sling-org-apache-sling-engine/commit/529802e2d538111336c60d98b35d16f2b9b3e51f would resolve the issue. Consumers can create valid requests with either SlingRequestBuilder or custom implementation of RequestProgressTracker after this change.
   
   cc: @rombert , @cziegeler


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org