[GitHub] [pinot] KKcorps commented on a diff in pull request #11685: Expose Additional Realtime Ingestion Metrics

["KKcorps (via GitHub)" <gi...@apache.org>]

KKcorps commented on code in PR #11685:
URL: https://github.com/apache/pinot/pull/11685#discussion_r1338344731


##########
docker/images/pinot/etc/jmx_prometheus_javaagent/configs/server.yml:
##########
@@ -85,6 +77,14 @@ rules:
 - pattern: "\"org.apache.pinot.common.metrics\"<type=\"ServerMetrics\", name=\"pinot.server.realtimeConsumptionExceptions\"><>(\\w+)"
   name: "pinot_server_realtime_consumptionExceptions_$1"
   cache: true
+- pattern: "\"org.apache.pinot.common.metrics\"<type=\"ServerMetrics\", name=\"pinot.server.([^\\.]*?)_(OFFLINE|REALTIME)\\-(.+)\\-(\\w+).(invalidRealtimeRowsDropped|incompleteRealtimeRowsConsumed|rowsWithErrors|realtimeRowsConsumed)\"><>(\\w+)"
+  name: "pinot_server_$4_$2"
+  cache: true
+  labels:
+    table: "$1"
+    tableType: "$2"
+    topic: "$3"
+    partition: "$5"

Review Comment:
   The partition label seems incorrect here. When I run your code I get the following 
   
   ```
   Input string 'pinot.server.meetupRsvp_OFFLINE-meetupRSVPEvents-1.realtimeRowsConsumed' matches the regex pattern: pinot.server.([^\.]*?)_(OFFLINE|REALTIME)\-(.+)\-(\w+).(invalidRealtimeRowsDropped|incompleteRealtimeRowsConsumed|rowsWithErrors|realtimeRowsConsumed)
   metricName: pinot.server.meetupRsvp_OFFLINE-meetupRSVPEvents-1.realtimeRowsConsumed
   Group 0: pinot.server.meetupRsvp_OFFLINE-meetupRSVPEvents-1.realtimeRowsConsumed
   Group 1: meetupRsvp
   Group 2: OFFLINE
   Group 3: meetupRSVPEvents
   Group 4: 1
   Group 5: realtimeRowsConsumed
   ```
   
   So it should be $4 and not $5, right?
   And metric name should contain $5 instead of $4



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org