You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Veena Basavaraj <vb...@cloudera.com> on 2014/12/24 17:12:06 UTC

Review Request 29401: IDF API and impementation package depednency

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29401/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-1870
    https://issues.apache.org/jira/browse/SQOOP-1870


Repository: sqoop-sqoop2


Description
-------

see jira


Diffs
-----

  connector/connector-generic-jdbc/pom.xml fc6cab4 
  connector/connector-hdfs/pom.xml 8b1e11f 
  connector/connector-kafka/pom.xml e8fea9b 
  connector/connector-kite/pom.xml 10ed099 
  connector/connector-sdk/src/main/java/org/apache/sqoop/configurable/ConfigurableError.java PRE-CREATION 
  connector/connector-sdk/src/main/java/org/apache/sqoop/configurable/ConfigurableUpgradeUtil.java PRE-CREATION 
  connector/connector-sdk/src/main/java/org/apache/sqoop/connector/spi/ConnectorConfigurableUpgrader.java PRE-CREATION 
  connector/connector-sdk/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java PRE-CREATION 
  connector/connector-sdk/src/main/java/org/apache/sqoop/job/Constants.java PRE-CREATION 
  connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Destroyer.java PRE-CREATION 
  connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Extractor.java PRE-CREATION 
  connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/From.java PRE-CREATION 
  connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Initializer.java PRE-CREATION 
  connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Loader.java PRE-CREATION 
  connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Partition.java PRE-CREATION 
  connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Partitioner.java PRE-CREATION 
  connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/To.java PRE-CREATION 
  connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Transferable.java PRE-CREATION 
  core/pom.xml 2b6e436 
  spi/src/main/java/org/apache/sqoop/configurable/ConfigurableError.java 83ed4a5 
  spi/src/main/java/org/apache/sqoop/configurable/ConfigurableUpgradeUtil.java 715a61c 
  spi/src/main/java/org/apache/sqoop/connector/spi/ConnectorConfigurableUpgrader.java b5e0c0d 
  spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java ff6392e 
  spi/src/main/java/org/apache/sqoop/job/Constants.java 90935cf 
  spi/src/main/java/org/apache/sqoop/job/etl/Destroyer.java 8486154 
  spi/src/main/java/org/apache/sqoop/job/etl/Extractor.java 85e91ef 
  spi/src/main/java/org/apache/sqoop/job/etl/From.java 3dd8fb9 
  spi/src/main/java/org/apache/sqoop/job/etl/Initializer.java 7dd156e 
  spi/src/main/java/org/apache/sqoop/job/etl/Loader.java e47b244 
  spi/src/main/java/org/apache/sqoop/job/etl/Partition.java db07844 
  spi/src/main/java/org/apache/sqoop/job/etl/Partitioner.java 3636130 
  spi/src/main/java/org/apache/sqoop/job/etl/To.java 64ba225 
  spi/src/main/java/org/apache/sqoop/job/etl/Transferable.java dfe1d5e 

Diff: https://reviews.apache.org/r/29401/diff/


Testing
-------


Thanks,

Veena Basavaraj


Re: Review Request 29401: IDF API and impementation package depednency

Posted by Veena Basavaraj <vb...@cloudera.com>.

> On Dec. 29, 2014, 7:03 p.m., Abraham Elmahrek wrote:
> > What about 'spi' folder name. Should we change it? Or do that in a different Jira?

not sure I got this point, another JIRA would be better in any case:)


- Veena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29401/#review66331
-----------------------------------------------------------


On Dec. 24, 2014, 6:40 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29401/
> -----------------------------------------------------------
> 
> (Updated Dec. 24, 2014, 6:40 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1870
>     https://issues.apache.org/jira/browse/SQOOP-1870
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   connector/connector-generic-jdbc/pom.xml fc6cab4 
>   connector/connector-hdfs/pom.xml 8b1e11f 
>   connector/connector-kafka/pom.xml e8fea9b 
>   connector/connector-kite/pom.xml 10ed099 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/configurable/ConfigurableError.java PRE-CREATION 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/configurable/ConfigurableUpgradeUtil.java PRE-CREATION 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/spi/ConnectorConfigurableUpgrader.java PRE-CREATION 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java PRE-CREATION 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/job/Constants.java PRE-CREATION 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Destroyer.java PRE-CREATION 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Extractor.java PRE-CREATION 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/From.java PRE-CREATION 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Initializer.java PRE-CREATION 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Loader.java PRE-CREATION 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Partition.java PRE-CREATION 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Partitioner.java PRE-CREATION 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/To.java PRE-CREATION 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Transferable.java PRE-CREATION 
>   core/pom.xml 2b6e436 
>   pom.xml afdeb75 
>   spi/src/main/java/org/apache/sqoop/configurable/ConfigurableError.java 83ed4a5 
>   spi/src/main/java/org/apache/sqoop/configurable/ConfigurableUpgradeUtil.java 715a61c 
>   spi/src/main/java/org/apache/sqoop/connector/spi/ConnectorConfigurableUpgrader.java b5e0c0d 
>   spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java ff6392e 
>   spi/src/main/java/org/apache/sqoop/job/Constants.java 90935cf 
>   spi/src/main/java/org/apache/sqoop/job/etl/Destroyer.java 8486154 
>   spi/src/main/java/org/apache/sqoop/job/etl/Extractor.java 85e91ef 
>   spi/src/main/java/org/apache/sqoop/job/etl/From.java 3dd8fb9 
>   spi/src/main/java/org/apache/sqoop/job/etl/Initializer.java 7dd156e 
>   spi/src/main/java/org/apache/sqoop/job/etl/Loader.java e47b244 
>   spi/src/main/java/org/apache/sqoop/job/etl/Partition.java db07844 
>   spi/src/main/java/org/apache/sqoop/job/etl/Partitioner.java 3636130 
>   spi/src/main/java/org/apache/sqoop/job/etl/To.java 64ba225 
>   spi/src/main/java/org/apache/sqoop/job/etl/Transferable.java dfe1d5e 
> 
> Diff: https://reviews.apache.org/r/29401/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Re: Review Request 29401: IDF API and impementation package depednency

Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29401/#review66331
-----------------------------------------------------------

Ship it!


What about 'spi' folder name. Should we change it? Or do that in a different Jira?

- Abraham Elmahrek


On Dec. 25, 2014, 2:40 a.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29401/
> -----------------------------------------------------------
> 
> (Updated Dec. 25, 2014, 2:40 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1870
>     https://issues.apache.org/jira/browse/SQOOP-1870
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   connector/connector-generic-jdbc/pom.xml fc6cab4 
>   connector/connector-hdfs/pom.xml 8b1e11f 
>   connector/connector-kafka/pom.xml e8fea9b 
>   connector/connector-kite/pom.xml 10ed099 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/configurable/ConfigurableError.java PRE-CREATION 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/configurable/ConfigurableUpgradeUtil.java PRE-CREATION 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/spi/ConnectorConfigurableUpgrader.java PRE-CREATION 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java PRE-CREATION 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/job/Constants.java PRE-CREATION 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Destroyer.java PRE-CREATION 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Extractor.java PRE-CREATION 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/From.java PRE-CREATION 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Initializer.java PRE-CREATION 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Loader.java PRE-CREATION 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Partition.java PRE-CREATION 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Partitioner.java PRE-CREATION 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/To.java PRE-CREATION 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Transferable.java PRE-CREATION 
>   core/pom.xml 2b6e436 
>   pom.xml afdeb75 
>   spi/src/main/java/org/apache/sqoop/configurable/ConfigurableError.java 83ed4a5 
>   spi/src/main/java/org/apache/sqoop/configurable/ConfigurableUpgradeUtil.java 715a61c 
>   spi/src/main/java/org/apache/sqoop/connector/spi/ConnectorConfigurableUpgrader.java b5e0c0d 
>   spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java ff6392e 
>   spi/src/main/java/org/apache/sqoop/job/Constants.java 90935cf 
>   spi/src/main/java/org/apache/sqoop/job/etl/Destroyer.java 8486154 
>   spi/src/main/java/org/apache/sqoop/job/etl/Extractor.java 85e91ef 
>   spi/src/main/java/org/apache/sqoop/job/etl/From.java 3dd8fb9 
>   spi/src/main/java/org/apache/sqoop/job/etl/Initializer.java 7dd156e 
>   spi/src/main/java/org/apache/sqoop/job/etl/Loader.java e47b244 
>   spi/src/main/java/org/apache/sqoop/job/etl/Partition.java db07844 
>   spi/src/main/java/org/apache/sqoop/job/etl/Partitioner.java 3636130 
>   spi/src/main/java/org/apache/sqoop/job/etl/To.java 64ba225 
>   spi/src/main/java/org/apache/sqoop/job/etl/Transferable.java dfe1d5e 
> 
> Diff: https://reviews.apache.org/r/29401/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Re: Review Request 29401: IDF API and impementation package depednency

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29401/
-----------------------------------------------------------

(Updated Dec. 24, 2014, 6:40 p.m.)


Review request for Sqoop.


Bugs: SQOOP-1870
    https://issues.apache.org/jira/browse/SQOOP-1870


Repository: sqoop-sqoop2


Description
-------

see jira


Diffs (updated)
-----

  connector/connector-generic-jdbc/pom.xml fc6cab4 
  connector/connector-hdfs/pom.xml 8b1e11f 
  connector/connector-kafka/pom.xml e8fea9b 
  connector/connector-kite/pom.xml 10ed099 
  connector/connector-sdk/src/main/java/org/apache/sqoop/configurable/ConfigurableError.java PRE-CREATION 
  connector/connector-sdk/src/main/java/org/apache/sqoop/configurable/ConfigurableUpgradeUtil.java PRE-CREATION 
  connector/connector-sdk/src/main/java/org/apache/sqoop/connector/spi/ConnectorConfigurableUpgrader.java PRE-CREATION 
  connector/connector-sdk/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java PRE-CREATION 
  connector/connector-sdk/src/main/java/org/apache/sqoop/job/Constants.java PRE-CREATION 
  connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Destroyer.java PRE-CREATION 
  connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Extractor.java PRE-CREATION 
  connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/From.java PRE-CREATION 
  connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Initializer.java PRE-CREATION 
  connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Loader.java PRE-CREATION 
  connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Partition.java PRE-CREATION 
  connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Partitioner.java PRE-CREATION 
  connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/To.java PRE-CREATION 
  connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Transferable.java PRE-CREATION 
  core/pom.xml 2b6e436 
  pom.xml afdeb75 
  spi/src/main/java/org/apache/sqoop/configurable/ConfigurableError.java 83ed4a5 
  spi/src/main/java/org/apache/sqoop/configurable/ConfigurableUpgradeUtil.java 715a61c 
  spi/src/main/java/org/apache/sqoop/connector/spi/ConnectorConfigurableUpgrader.java b5e0c0d 
  spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java ff6392e 
  spi/src/main/java/org/apache/sqoop/job/Constants.java 90935cf 
  spi/src/main/java/org/apache/sqoop/job/etl/Destroyer.java 8486154 
  spi/src/main/java/org/apache/sqoop/job/etl/Extractor.java 85e91ef 
  spi/src/main/java/org/apache/sqoop/job/etl/From.java 3dd8fb9 
  spi/src/main/java/org/apache/sqoop/job/etl/Initializer.java 7dd156e 
  spi/src/main/java/org/apache/sqoop/job/etl/Loader.java e47b244 
  spi/src/main/java/org/apache/sqoop/job/etl/Partition.java db07844 
  spi/src/main/java/org/apache/sqoop/job/etl/Partitioner.java 3636130 
  spi/src/main/java/org/apache/sqoop/job/etl/To.java 64ba225 
  spi/src/main/java/org/apache/sqoop/job/etl/Transferable.java dfe1d5e 

Diff: https://reviews.apache.org/r/29401/diff/


Testing
-------


Thanks,

Veena Basavaraj