You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/14 08:24:39 UTC

[GitHub] [spark] MaxGekk commented on a diff in pull request #38646: [SPARK-41131][SQL] Improve error message for `UNRESOLVED_MAP_KEY.WITHOUT_SUGGESTION`

MaxGekk commented on code in PR #38646:
URL: https://github.com/apache/spark/pull/38646#discussion_r1021194056


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1044,7 +1044,7 @@
   },
   "UNRESOLVED_MAP_KEY" : {
     "message" : [
-      "Cannot resolve column <objectName> as a map key. If the key is a string literal, please add single quotes around it."
+      "Cannot resolve column <objectName> as a map key. If the key is a string literal, add single quotes around it: '<object_name>'."

Review Comment:
   1. I don't see that we pass `object_name`. Maybe, `objectName`?
   2. We quite `objectName` by back ticks, and how it will looks like ```'`a`'```?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org