You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/27 01:48:59 UTC

[GitHub] [spark] zhengruifeng edited a comment on pull request #29868: [SPARK-32973][ML][DOC] FeatureHasher does not check categoricalCols in inputCols

zhengruifeng edited a comment on pull request #29868:
URL: https://github.com/apache/spark/pull/29868#issuecomment-699571847


   > This is still 'required' right?
   
   yes. This algorithm was designed to have this requirement. But I guess `must` may suggest an exception/error, so what about changing `must` -> `should`?
   @srowen @viirya 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org