You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/11/03 11:32:59 UTC

[jira] [Commented] (FLINK-3930) Implement Service-Level Authorization

    [ https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15632473#comment-15632473 ] 

ASF GitHub Bot commented on FLINK-3930:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2425#discussion_r86321008
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java ---
    @@ -64,26 +64,25 @@
     
     	static final String NO_SECURE_COOKIE = "";
     
    -	static final Charset DEFAULT_CHARSET = Charset.forName("utf-8");
    -
     	abstract ByteBuf write(ByteBufAllocator allocator) throws Exception;
     
     	abstract void readFrom(ByteBuf buffer) throws Exception;
     
     	// ------------------------------------------------------------------------
     
     	private static ByteBuf allocateBuffer(ByteBufAllocator allocator, byte id, String secureCookie) {
    -		return allocateBuffer(allocator, id, secureCookie, 0);
    +		return allocateBuffer(allocator, id, 0, secureCookie);
     	}
     
    -	private static ByteBuf allocateBuffer(ByteBufAllocator allocator, byte id, String secureCookie, int length) {
    +	private static ByteBuf allocateBuffer(ByteBufAllocator allocator, byte id, int length, String secureCookie) {
    +		final Charset DEFAULT_CHARSET = Charset.forName("utf-8");
     		secureCookie = secureCookie == null ? "": secureCookie;
    --- End diff --
    
    Simpler:
    ```java
    if (secureCookie == null) {
        secureCookie = NO_SECURE_COOKIE;
    }
    ```


> Implement Service-Level Authorization
> -------------------------------------
>
>                 Key: FLINK-3930
>                 URL: https://issues.apache.org/jira/browse/FLINK-3930
>             Project: Flink
>          Issue Type: New Feature
>          Components: Security
>            Reporter: Eron Wright 
>            Assignee: Vijay Srinivasaraghavan
>              Labels: security
>   Original Estimate: 672h
>  Remaining Estimate: 672h
>
> _This issue is part of a series of improvements detailed in the [Secure Data Access|https://docs.google.com/document/d/1-GQB6uVOyoaXGwtqwqLV8BHDxWiMO2WnVzBoJ8oPaAs/edit?usp=sharing] design doc._
> Service-level authorization is the initial authorization mechanism to ensure clients (or servers) connecting to the Flink cluster are authorized to do so.   The purpose is to prevent a cluster from being used by an unauthorized user, whether to execute jobs, disrupt cluster functionality, or gain access to secrets stored within the cluster.
> Implement service-level authorization as described in the design doc.
> - Introduce a shared secret cookie
> - Enable Akka security cookie
> - Implement data transfer authentication
> - Secure the web dashboard



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)