You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "jakubmatyszewski (via GitHub)" <gi...@apache.org> on 2023/07/21 09:49:42 UTC
[PR] docs: k8s-jobs peonMonitors info extended (druid)
jakubmatyszewski opened a new pull request, #14637:
URL: https://github.com/apache/druid/pull/14637
Stems from [#14599](https://github.com/apache/druid/issues/14599).
### Description
Extends [instructions of MM-less `druid-overlord-extension`](https://druid.apache.org/docs/latest/development/extensions-contrib/k8s-jobs.html). I've changed wording in docs of `druid.indexer.runner.peonMonitors` option, since it doesn't override Overlord's `druid.monitoring.monitors` but rather it overrides peon pod's `druid_monitoring_monitors` environment variable.
For this to work properly I use a workaround described in _Gotchas_ section, where I use `druid_monitoring_monitors` variable in definition of Overlord monitors.
Possible improvement would be to avoid using `druid_monitoring_monitors` env variable and directly override `runtime.properties` that peon pod's would use. But I'm not proficient in java, so I'm not sure if that's possible to be implemented.
I'm not sure if this is best wording and if this workaround is good enough, but this at least clears ambiguous description that resulted in breaking errors.
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [x] been self-reviewed.
- [x] added documentation for new or modified features or behaviors.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] docs: k8s-jobs peonMonitors info extended (druid)
Posted by "ektravel (via GitHub)" <gi...@apache.org>.
ektravel commented on code in PR #14637:
URL: https://github.com/apache/druid/pull/14637#discussion_r1300344043
##########
docs/development/extensions-contrib/k8s-jobs.md:
##########
@@ -145,3 +145,8 @@ roleRef:
name: druid-cluster
apiGroup: rbac.authorization.k8s.io
```
+
+To use `druid.indexer.runner.peonMonitors` option properly define Overlord's monitors like below:
Review Comment:
```suggestion
To use the `druid.indexer.runner.peonMonitors` option, configure monitors on the Overlord as follows:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] docs: k8s-jobs peonMonitors info extended (druid)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14637:
URL: https://github.com/apache/druid/pull/14637#issuecomment-1998681215
This pull request/issue has been closed due to lack of activity. If you think that
is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] docs: k8s-jobs peonMonitors info extended (druid)
Posted by "ektravel (via GitHub)" <gi...@apache.org>.
ektravel commented on code in PR #14637:
URL: https://github.com/apache/druid/pull/14637#discussion_r1300339564
##########
docs/development/extensions-contrib/k8s-jobs.md:
##########
@@ -81,7 +81,7 @@ Additional Configuration
|`druid.indexer.runner.javaOptsArray`|`JsonArray`|java opts for the task.|`-Xmx1g`|No|
|`druid.indexer.runner.labels`|`JsonObject`|Additional labels you want to add to peon pod|`{}`|No|
|`druid.indexer.runner.annotations`|`JsonObject`|Additional annotations you want to add to peon pod|`{}`|No|
-|`druid.indexer.runner.peonMonitors`|`JsonArray`|Overrides `druid.monitoring.monitors`. Use this property if you don't want to inherit monitors from the Overlord.|`[]`|No|
+|`druid.indexer.runner.peonMonitors`|`JsonArray`|Overrides peon pod's `druid_monitoring_monitors` environment variable. Use this property if you don't want to inherit monitors from the Overlord.|`[]`|No|
Review Comment:
```suggestion
|`druid.indexer.runner.peonMonitors`|`JsonArray`|Overrides the `druid.monitoring.monitors` environment variable of a peon pod. Use this property if you don't want to inherit monitors from the Overlord.|`[]`|No|
```
configure monitors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] docs: k8s-jobs peonMonitors info extended (druid)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #14637: docs: k8s-jobs peonMonitors info extended
URL: https://github.com/apache/druid/pull/14637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] docs: k8s-jobs peonMonitors info extended (druid)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14637:
URL: https://github.com/apache/druid/pull/14637#issuecomment-1945128626
This pull request has been marked as stale due to 60 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If you think
that's incorrect or this pull request should instead be reviewed, please simply
write any comment. Even if closed, you can still revive the PR at any time or
discuss it on the dev@druid.apache.org list.
Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org