You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "hantangwangd (via GitHub)" <gi...@apache.org> on 2024/08/13 07:47:38 UTC
[I] Spec: The spec about metadata key `schema-id` in manifest file do not match the lib implementation [iceberg]
hantangwangd opened a new issue, #10927:
URL: https://github.com/apache/iceberg/issues/10927
### Query engine
N/A
### Question
Referring to: https://iceberg.apache.org/spec/#manifests, iceberg spec about `manifests` defines that, a manifest file must store the partition spec and other metadata as properties in the Avro file's key-value metadata. Among these key-value metadata, `schema-id` has changed from `optional` to `required` in v2 metadata.
However, in any implementation version of `ManifestWriter`, we did not write `schema-id` into the metadata of the corresponding Avro file. This looks inconsistent with the spec. And furthermore, seems there is not need to write this key-value property as it is not used anywhere. So should we fix this inconsistency? Or did I misunderstand something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Spec: The spec about metadata key `schema-id` in manifest file do not match the lib implementation [iceberg]
Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on issue #10927:
URL: https://github.com/apache/iceberg/issues/10927#issuecomment-2285897292
@hantangwangd: Good catch.
JSON representation of `schema` already have the `schema-id`. So, I am not sure why we need one more field `schema-id` in the Avro metadata?
Also, if we see `partition-spec` it is the JSON representation of the fields of the spec. Not the entire spec. Hence, we need `partition-spec-id`.
the `schema-id` field seems irrelevant in the spec. Lets see what others think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Spec: The spec about metadata key `schema-id` in manifest file do not match the lib implementation [iceberg]
Posted by "hantangwangd (via GitHub)" <gi...@apache.org>.
hantangwangd commented on issue #10927:
URL: https://github.com/apache/iceberg/issues/10927#issuecomment-4588889150
Thanks @Tishj for bringing attention back to this question, and thanks @RussellSpitzer for the clarification.
Would be great to re-open it and continue the discussion. It looks like I don't have permission to re-open it, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Spec: The spec about metadata key `schema-id` in manifest file do not match the lib implementation [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #10927:
URL: https://github.com/apache/iceberg/issues/10927#issuecomment-2646674110
This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Spec: The spec about metadata key `schema-id` in manifest file do not match the lib implementation [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #10927: Spec: The spec about metadata key `schema-id` in manifest file do not match the lib implementation
URL: https://github.com/apache/iceberg/issues/10927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Spec: The spec about metadata key `schema-id` in manifest file do not match the lib implementation [iceberg]
Posted by "Tishj (via GitHub)" <gi...@apache.org>.
Tishj commented on issue #10927:
URL: https://github.com/apache/iceberg/issues/10927#issuecomment-4586658321
Love how this got closed as "not planned" but the actual spec remains unchanged..
If you vote that `schema-id` is redundant, why was it explicitly changed from `optional` to `required` instead of the other way around..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Spec: The spec about metadata key `schema-id` in manifest file do not match the lib implementation [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #10927:
URL: https://github.com/apache/iceberg/issues/10927#issuecomment-2677206683
This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Spec: The spec about metadata key `schema-id` in manifest file do not match the lib implementation [iceberg]
Posted by "RussellSpitzer (via GitHub)" <gi...@apache.org>.
RussellSpitzer commented on issue #10927:
URL: https://github.com/apache/iceberg/issues/10927#issuecomment-4587525230
That's a bot @Tishj and doesn't really have a value judgement on the issue in question. I think there just hasn't been any focus on this issue.
I'm sure if someone would like to fix the library we could do so. I think the current issue is that we don't actually have any consumers of this field. Would you like to re-open it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org