You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2026/08/03 11:36:32 UTC
[PR] Update Pulsar client from `4.1.2` to `4.2.4` [pulsar-client-reactive]
lhotari opened a new pull request, #234:
URL: https://github.com/apache/pulsar-client-reactive/pull/234
This commit updates the following dependency version:
- Pulsar from `4.1.2` to `4.2.4`
### Test fix required by the upgrade
Two tests in `AdaptedReactiveMessageConsumerTests` (`keySharedPolicy` and `topicsPattern`) started failing with `didn't match expected consumer conf`.
Pulsar 4.2 added the `DecryptFailListener` feature and changed how `cryptoFailureAction` is defaulted:
- **4.1.x** — `ConsumerConfigurationData.cryptoFailureAction` was initialized to `ConsumerCryptoFailureAction.FAIL` at field declaration.
- **4.2.x** — the field now defaults to `null`. `ConsumerBuilderImpl.subscribeAsync` rejects setting both `decryptFailListener` and `cryptoFailureAction`, and applies `FAIL` to the conf just before subscribing only when *neither* is set.
These tests stub `subscribeAsync(eq(expectedConsumerConf), ...)` with a `ConsumerConfigurationData` built by hand, falling back to a future that fails with `didn't match expected consumer conf`. The expected conf held `null` for `cryptoFailureAction` while the conf actually passed by the builder held `FAIL`, so the stub no longer matched. `consumerProperties` was unaffected because it sets `DISCARD` explicitly on both sides.
The fix sets the expected default explicitly in the two tests.
### No production change
`AdaptedReactiveMessageConsumer.configureConsumerBuilder` correctly leaves `cryptoFailureAction` unset when the spec does not specify it, which lets Pulsar apply its own default. Hardcoding `FAIL` in the adapter would preserve current behavior but would permanently block `decryptFailListener` should it ever be exposed through `ReactiveMessageConsumerSpec`.
### Verification
`./gradlew check` passes: 149 tests, 0 failures, 0 errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Pulsar client from `4.1.2` to `4.2.4` [pulsar-client-reactive]
Posted by "onobc (via GitHub)" <gi...@apache.org>.
onobc merged PR #234:
URL: https://github.com/apache/pulsar-client-reactive/pull/234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org