[GitHub] incubator-apex-malhar pull request: [review only] APEXMALHAR-1948:...

[bhupeshchawda <gi...@git.apache.org>]

Github user bhupeshchawda commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/188#discussion_r55978278
  
    --- Diff: contrib/src/main/java/com/datatorrent/contrib/cassandra/CassandraStore.java ---
    @@ -115,21 +130,35 @@ public Session getSession() {
       /**
        * Creates a cluster object.
        */
    -  public void buildCluster(){
    -
    +  public void buildCluster()
    +  {
         try {
    -
    -      cluster = Cluster.builder()
    -          .addContactPoint(node).withCredentials(userName, password).build();
    -    }
    -    catch (DriverException ex) {
    +      if (protocolVersion != null && protocolVersion.length() != 0) {
    +        ProtocolVersion version = getCassandraProtocolVersion();
    +        cluster = Cluster.builder().addContactPoint(node).withCredentials(userName, password).withProtocolVersion(version).build();
    +      } else {
    --- End diff --
    
    which version does it use in the default case? Should we add a specific default? Like for example, the latest version?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---