You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ethanluoyc <gi...@git.apache.org> on 2016/09/28 13:02:37 UTC
[GitHub] spark pull request #15279: SPARK-12347 [ML] Add a script to test Spark ML ex...
GitHub user ethanluoyc opened a pull request:
https://github.com/apache/spark/pull/15279
SPARK-12347 [ML] Add a script to test Spark ML examples.
This PR addresses [SPARK-12347](https://issues.apache.org/jira/browse/SPARK-12347?jql=project%20%3D%20SPARK%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20ML%20ORDER%20BY%20priority%20DESC) and may also be helpful for [SPARK-15571](https://issues.apache.org/jira/browse/SPARK-15571).
## What changes were proposed in this pull request?
This PR adds a python script to drive all the examples located in the `examples` subdirectory. It should be able to streamline the testing of the examples in R, Python, Scala and Java to see if any of them has incompatible behavior with the codebase.
## How was this patch tested?
This PR is not yet fully ready for merging. I would like to have some reviews for how it works best for those who will indeed be using this script. For now, it introduces the following features:
- [x] select examples of a specific language to run (R, Python, Scala or Java)
- [x] running in parallem (like that in run-test.py)
- [ ] Configuring according to environment variables.
- [ ] **Run those examples requiring arguments to be passed in.**
Note that the last TODO is really important, for that I would like to hear suggestions from the reviewers for how it should should be best implemented. For now, I think one good way will be to have comments as directives in the example code. Like how ` # $example on$` are introduced to facilitate doc generation. We can do something similar to hint what arguments should be passed in for testing. Otherwise, we can always fall back to the way we discussed in the JIRA [SPARK-12347](https://issues.apache.org/jira/browse/SPARK-12347)
Also, some of the functionality replicates that in run-tests.py. Perhaps we can find a way to integrate both?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ethanluoyc/spark test-examples
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/15279.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15279
----
commit c566a5bfe72aa9be10d9b3f90ea18ec0d0382f93
Author: ethanluoyc <et...@gmail.com>
Date: 2016-09-28T12:35:38Z
Add a script to test Spark examples.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15279
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15279
**[Test build #72787 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72787/testReport)** for PR 15279 at commit [`276eddd`](https://github.com/apache/spark/commit/276eddd749ee4a9101be65039be57e1f5a180b58).
* This patch **fails Python style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML] Add a script to test Spark ML examples.
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15279
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by ethanluoyc <gi...@git.apache.org>.
Github user ethanluoyc commented on the issue:
https://github.com/apache/spark/pull/15279
@felixcheung I think we can, although it requires changes to every examples. If you are fine with that, I can start on some of the examples from now onwards:D
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15279
Hi, @ethanluoyc .
Could you add Apache License, too?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by jkbradley <gi...@git.apache.org>.
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/15279
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/15279
Hi - how are we on this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by ethanluoyc <gi...@git.apache.org>.
Github user ethanluoyc commented on the issue:
https://github.com/apache/spark/pull/15279
For example https://github.com/apache/spark/blob/master/examples/src/main/python/parquet_inputformat.py#L26. It requires that we pass in jar files, which are not so easy to detect directly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by ethanluoyc <gi...@git.apache.org>.
Github user ethanluoyc commented on the issue:
https://github.com/apache/spark/pull/15279
@felixcheung I actually agree with you on examples being self contained. In that case, the example authors can just declare the arguments in the examples.
What I think may be appropriate will be some macro kind of text in the examples themselves. (e.g. like an shebang line but for files.) Then instead of looking for the arguments in the yml we can look for it in the examples.
Another way to do it will be to let the examples be ready in passing in their own default arguments. But I would not say this is a good idea because then all examples will need to be modified.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by ethanluoyc <gi...@git.apache.org>.
Github user ethanluoyc commented on the issue:
https://github.com/apache/spark/pull/15279
@felixcheung Last time I was working on this PR, the main challenge is to work out a nice way to record the examples that require input, and pass those arguments properly. Do you have any suggestion on that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ...
Posted by ethanluoyc <gi...@git.apache.org>.
Github user ethanluoyc closed the pull request at:
https://github.com/apache/spark/pull/15279
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by ethanluoyc <gi...@git.apache.org>.
Github user ethanluoyc commented on the issue:
https://github.com/apache/spark/pull/15279
@felixcheung I changed two examples in python. These are the simple ones. However, some of the examples take really complicated arguments and I am not sure if doing it in this way would scale. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/15279
that looks reasonable. could you point me to the ones with complicated argument you were referring to?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15279
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70088/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15279
**[Test build #71768 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71768/testReport)** for PR 15279 at commit [`7d5ea6d`](https://github.com/apache/spark/commit/7d5ea6d432f30d1a85076271da988594de248470).
* This patch **fails Python style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/15279
@ethanluoyc this seems reasonable although I'm not 100% how this go yet. `wordcount.py` in the yml file - does it mean 1 yml for all examples? I think perhaps we need a way for the example to be self-contained, say on disk so someone can take a subdirectory and run by itself, with default values for parameters?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by ethanluoyc <gi...@git.apache.org>.
Github user ethanluoyc commented on the issue:
https://github.com/apache/spark/pull/15279
@HyukjinKwon I am really sorry but please close this since I have not found the time to complete all the cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15279
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15279
Hi @ethanluoyc, is it still WIP? I would rather like to propose to close this if it is inactive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15279
**[Test build #68646 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68646/consoleFull)** for PR 15279 at commit [`c566a5b`](https://github.com/apache/spark/commit/c566a5bfe72aa9be10d9b3f90ea18ec0d0382f93).
* This patch **fails RAT tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15279
**[Test build #72787 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72787/testReport)** for PR 15279 at commit [`276eddd`](https://github.com/apache/spark/commit/276eddd749ee4a9101be65039be57e1f5a180b58).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15279
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71768/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15279
**[Test build #70088 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70088/consoleFull)** for PR 15279 at commit [`7b9fe15`](https://github.com/apache/spark/commit/7b9fe15513c4ee3b4fac565cdf54973d78cdd4db).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15279#discussion_r100702360
--- Diff: examples/src/main/python/sort.py ---
@@ -23,9 +23,11 @@
if __name__ == "__main__":
- if len(sys.argv) != 2:
- print("Usage: sort <file>", file=sys.stderr)
- exit(-1)
+ """
+ Usage: sort <file>
+ """
+
+ filename = "../resources/people.txt" if len(sys.argv) != 2 else sys.args[1]
--- End diff --
I think maybe better to reference relative to SPARK_HOME?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/15279
shall we use `spark.driver.extraClassPath` in that case?
in python these we could set as options to SparkSession
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15279
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/15279
perhaps a test driver .yml file?
or perhaps it is better to change example to have default input values so they run standalone if no input is passed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15279
**[Test build #68646 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68646/consoleFull)** for PR 15279 at commit [`c566a5b`](https://github.com/apache/spark/commit/c566a5bfe72aa9be10d9b3f90ea18ec0d0382f93).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/15279
What if we have a bunch of default values when arguments are not set, and those are the values we could test with? This way the same sample code can run with and without arguments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by ethanluoyc <gi...@git.apache.org>.
Github user ethanluoyc commented on the issue:
https://github.com/apache/spark/pull/15279
@felixcheung I uploaded the yaml file for configuring the arguments passed into examples.
Basically, what we need to do now is to fill in the yaml with all the examples. And look for a way to exclude examples as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/15279
I think that should be reasonable, but let's start with one or two and discuss. thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15279
**[Test build #71768 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71768/testReport)** for PR 15279 at commit [`7d5ea6d`](https://github.com/apache/spark/commit/7d5ea6d432f30d1a85076271da988594de248470).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15279
**[Test build #70088 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70088/consoleFull)** for PR 15279 at commit [`7b9fe15`](https://github.com/apache/spark/commit/7b9fe15513c4ee3b4fac565cdf54973d78cdd4db).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15279
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72787/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15279
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68646/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15279#discussion_r100702396
--- Diff: examples/src/main/python/sort.py ---
@@ -23,9 +23,11 @@
if __name__ == "__main__":
- if len(sys.argv) != 2:
- print("Usage: sort <file>", file=sys.stderr)
- exit(-1)
+ """
+ Usage: sort <file>
+ """
+
+ filename = "../resources/people.txt" if len(sys.argv) != 2 else sys.args[1]
--- End diff --
you probably would have one check `if len(sys.argv) > 1` and then set all parameter in the if block - we can assume if any parameter is there the user needs to specify all of it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by jkbradley <gi...@git.apache.org>.
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/15279
Can you please change the title to have: "SPARK-12347" -> "[SPARK-12347]"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML] Add a script to test Spark ML examples.
Posted by holdenk <gi...@git.apache.org>.
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/15279
So at first glance this seems like it might be a work in progress PR - if that is the case you can tag it with [WIP] in the title. I think if we had a blacklist of examples not to run this could be a good start, and then we would want to add it to jenkins script. I'll try and follow up next week with a more thorough examination :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15279
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org