You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2026/07/16 17:38:38 UTC
[I] Code coverage report not working [datafusion]
alamb opened a new issue, #23647:
URL: https://github.com/apache/datafusion/issues/23647
when i open https://app.codecov.io/gh/apache/datafusion it seems to show `master` as default
<img width="1277" height="822" alt="image" src="https://github.com/user-attachments/assets/0e54d1c7-3cf6-4b85-99e5-690e8b7e116e" />
- the latest commit shown there seems to be pretty old https://github.com/apache/datafusion/commit/a9f7cac
i cant seem to find `main` in the dropdown
<img width="292" height="155" alt="image" src="https://github.com/user-attachments/assets/78073586-186e-44fb-95d9-b5faf8816353" />
is this an issue we need to fix? i see a comment on my PR how base (main) doesnt have a coverage report uploaded, is this related?
- https://github.com/apache/datafusion/pull/23631#issuecomment-4991098008
edit: or maybe its still processing on codecov's end
_Originally posted by @Jefffrey in https://github.com/apache/datafusion/issues/23336#issuecomment-4991162112_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Code coverage report not working [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #23647:
URL: https://github.com/apache/datafusion/issues/23647#issuecomment-4994864169
https://github.com/apache/datafusion/pull/23336#issuecomment-4991235724 from @Jefffrey (error about token required)
> oh im seeing this log on main:
>
> ```
> info - 2026-07-16 10:36:05,200 -- Found 1 coverage files to report
> info - 2026-07-16 10:36:05,200 -- > /__w/datafusion/datafusion/target/codecov.json
> info - 2026-07-16 10:36:05,651 -- Upload queued for processing complete
> error - 2026-07-16 10:36:05,651 -- Upload queued for processing failed: {"message":"Token required because branch is protected"}
> ```
>
> * https://github.com/apache/datafusion/actions/runs/29490778583/job/87596785411
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Code coverage report not working [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #23647:
URL: https://github.com/apache/datafusion/issues/23647#issuecomment-5002516998
> by default it still has master on the homepage; i tried logging in to change it but dont think i have the required access to do so 🤔
I logged in and changed the default branch (I am not sure how I have access -- maybe just by authorizing via github because I have write access to the report)
<img width="1442" height="751" alt="Image" src="https://github.com/user-attachments/assets/dc7fcbab-7c31-43e1-a140-1b47eafc74a2" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Code coverage report not working [datafusion]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on issue #23647:
URL: https://github.com/apache/datafusion/issues/23647#issuecomment-4999754181
looks like comparing against main works now
https://github.com/apache/datafusion/pull/22695#issuecomment-4999373822
and i can find main on the website: https://app.codecov.io/gh/apache/datafusion/tree/main
by default it still has master on the homepage; i tried logging in to change it but dont think i have the required access to do so 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Code coverage report not working [datafusion]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on issue #23647:
URL: https://github.com/apache/datafusion/issues/23647#issuecomment-5002860934
looks like we're good to close this now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Code coverage report not working [datafusion]
Posted by "buraksenn (via GitHub)" <gi...@apache.org>.
buraksenn commented on issue #23647:
URL: https://github.com/apache/datafusion/issues/23647#issuecomment-4994943463
Then an admin needs to change default branch to main in codecov: https://community.codecov.com/t/codecov-default-branch-doesn-t-match-gh-default-branch/4442/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Code coverage report not working [datafusion]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey closed issue #23647: Code coverage report not working
URL: https://github.com/apache/datafusion/issues/23647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Code coverage report not working [datafusion]
Posted by "buraksenn (via GitHub)" <gi...@apache.org>.
buraksenn commented on issue #23647:
URL: https://github.com/apache/datafusion/issues/23647#issuecomment-4994887807
It was using `CODECOV_TOKEN` from repository secrets and since I saw it was working in my branch I did not ping any maintainer about this.
```
- name: Upload coverage to codecov.io
uses: codecov/codecov-action@0fb7174895f61a3b6b78fc075e0cd60383518dac # v5
with:
files: target/codecov.json
fail_ci_if_error: false
token: ${{ secrets.CODECOV_TOKEN }}
```
I think this needs to be checked but I'll take a look in detail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Code coverage report not working [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #23647:
URL: https://github.com/apache/datafusion/issues/23647#issuecomment-4996023805
Ok, I added the CODECOV_TOKEN from the codecov UI to https://github.com/apache/datafusion/settings/secrets/actions
<img width="1105" height="545" alt="Image" src="https://github.com/user-attachments/assets/a3e15924-8b8b-45e0-b18f-43d193b7ce89" />
Let's see if that fixes the problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org