[GitHub] [superset] rusackas commented on a diff in pull request #24751: docs: update AWS Athena and Redshift docs

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on code in PR #24751:
URL: https://github.com/apache/superset/pull/24751#discussion_r1271143246


##########
docs/docs/databases/athena.mdx:
##########
@@ -33,10 +33,8 @@ following connection string:
 awsathena+rest://{aws_access_key_id}:{aws_secret_access_key}@athena.{region_name}.amazonaws.com/{schema_name}?s3_staging_dir={s3_staging_dir}&...
 ```
 
-The PyAthena library also allows to assume a specific IAM role, by [importing the datasource from YAML](https://superset.apache.org/docs/miscellaneous/importing-exporting-datasources/#importing-datasources-from-yaml) and passing extra parameters:
+The PyAthena library also allows to assume a specific IAM role which you can define by adding following parameters in Superset's Athena database connection UI under ADVANCED --> Other --> ENGINE PARAMETERS.
 ```
-databases:
-  - database_name: awsathena
-    sqlalchemy_uri: awsathena+rest://athena.{region_name}.amazonaws.com/{schema_name}?s3_staging_dir={s3_staging_dir}&...
-    extra: "{\"engine_params\": {\"connect_args\": {\"role_arn\": \"{{  ROLE_ARN  }}\" }}}"
+{"connect_args":{"role_arn":"<role arn>"}}
 ```
+

Review Comment:
   ```suggestion
   ```
   Seems linting doesn't like this extra line



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org