You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "taiyang-li (via GitHub)" <gi...@apache.org> on 2024/08/14 04:11:14 UTC
[PR] [GLUTEN-6819][CH] Refactor source from jave iter [incubator-gluten]
taiyang-li opened a new pull request, #6830:
URL: https://github.com/apache/incubator-gluten/pull/6830
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
(Fixes: \#6819)
## How was this patch tested?
original uts in
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-6819][CH] Refactor source from jave iter && make casting happens before materializing [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6830:
URL: https://github.com/apache/incubator-gluten/pull/6830#issuecomment-2287977378
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-6819][CH] Refactor source from jave iter && make casting happens before materializing [incubator-gluten]
Posted by "GlutenPerfBot (via GitHub)" <gi...@apache.org>.
GlutenPerfBot commented on PR #6830:
URL: https://github.com/apache/incubator-gluten/pull/6830#issuecomment-2289552917
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
<table border="1" cellpadding="0" cellspacing="0">
<tbody>
<tr>
<td><font color=#000000>query</font></td>
<td><font color=#000000>log/native_master_08_14_2024_time.csv</font></td>
<td><font color=#000000>log/native_master_08_13_2024_e9882d192b_time.csv</font></td>
<td><font color=#000000>difference</font></td>
<td><font color=#000000>percentage</font></td>
</tr>
<tr>
<td><font color=#F92663>q1</font></td>
<td><font color=#F92663>39.02</font></td>
<td><font color=#F92663>39.60</font></td>
<td><font color=#F92663>0.582</font></td>
<td><font color=#F92663>101.49%</font></td>
</tr>
<tr>
<td><font color=#F92663>q2</font></td>
<td><font color=#F92663>29.62</font></td>
<td><font color=#F92663>30.40</font></td>
<td><font color=#F92663>0.788</font></td>
<td><font color=#F92663>102.66%</font></td>
</tr>
<tr>
<td><font color=#F92663>q3</font></td>
<td><font color=#F92663>51.65</font></td>
<td><font color=#F92663>51.99</font></td>
<td><font color=#F92663>0.334</font></td>
<td><font color=#F92663>100.65%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q4</font></td>
<td><font color=#6F9915>42.92</font></td>
<td><font color=#6F9915>41.95</font></td>
<td><font color=#6F9915>-0.970</font></td>
<td><font color=#6F9915>97.74%</font></td>
</tr>
<tr>
<td><font color=#F92663>q5</font></td>
<td><font color=#F92663>103.89</font></td>
<td><font color=#F92663>104.86</font></td>
<td><font color=#F92663>0.970</font></td>
<td><font color=#F92663>100.93%</font></td>
</tr>
<tr>
<td><font color=#F92663>q6</font></td>
<td><font color=#F92663>11.18</font></td>
<td><font color=#F92663>13.09</font></td>
<td><font color=#F92663>1.912</font></td>
<td><font color=#F92663>117.10%</font></td>
</tr>
<tr>
<td><font color=#F92663>q7</font></td>
<td><font color=#F92663>115.76</font></td>
<td><font color=#F92663>118.53</font></td>
<td><font color=#F92663>2.773</font></td>
<td><font color=#F92663>102.40%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q8</font></td>
<td><font color=#6F9915>115.92</font></td>
<td><font color=#6F9915>114.40</font></td>
<td><font color=#6F9915>-1.514</font></td>
<td><font color=#6F9915>98.69%</font></td>
</tr>
<tr>
<td><font color=#F92663>q9</font></td>
<td><font color=#F92663>168.25</font></td>
<td><font color=#F92663>168.84</font></td>
<td><font color=#F92663>0.588</font></td>
<td><font color=#F92663>100.35%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q10</font></td>
<td><font color=#6F9915>65.66</font></td>
<td><font color=#6F9915>64.27</font></td>
<td><font color=#6F9915>-1.387</font></td>
<td><font color=#6F9915>97.89%</font></td>
</tr>
<tr>
<td><font color=#F92663>q11</font></td>
<td><font color=#F92663>25.87</font></td>
<td><font color=#F92663>26.58</font></td>
<td><font color=#F92663>0.709</font></td>
<td><font color=#F92663>102.74%</font></td>
</tr>
<tr>
<td><font color=#F92663>q12</font></td>
<td><font color=#F92663>30.71</font></td>
<td><font color=#F92663>31.53</font></td>
<td><font color=#F92663>0.821</font></td>
<td><font color=#F92663>102.67%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q13</font></td>
<td><font color=#6F9915>51.84</font></td>
<td><font color=#6F9915>51.57</font></td>
<td><font color=#6F9915>-0.270</font></td>
<td><font color=#6F9915>99.48%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q14</font></td>
<td><font color=#6F9915>26.31</font></td>
<td><font color=#6F9915>24.44</font></td>
<td><font color=#6F9915>-1.871</font></td>
<td><font color=#6F9915>92.89%</font></td>
</tr>
<tr>
<td><font color=#F92663>q15</font></td>
<td><font color=#F92663>53.60</font></td>
<td><font color=#F92663>55.28</font></td>
<td><font color=#F92663>1.678</font></td>
<td><font color=#F92663>103.13%</font></td>
</tr>
<tr>
<td><font color=#F92663>q16</font></td>
<td><font color=#F92663>18.19</font></td>
<td><font color=#F92663>19.49</font></td>
<td><font color=#F92663>1.305</font></td>
<td><font color=#F92663>107.17%</font></td>
</tr>
<tr>
<td><font color=#F92663>q17</font></td>
<td><font color=#F92663>130.87</font></td>
<td><font color=#F92663>132.56</font></td>
<td><font color=#F92663>1.697</font></td>
<td><font color=#F92663>101.30%</font></td>
</tr>
<tr>
<td><font color=#F92663>q18</font></td>
<td><font color=#F92663>196.20</font></td>
<td><font color=#F92663>197.76</font></td>
<td><font color=#F92663>1.561</font></td>
<td><font color=#F92663>100.80%</font></td>
</tr>
<tr>
<td><font color=#F92663>q19</font></td>
<td><font color=#F92663>28.20</font></td>
<td><font color=#F92663>31.36</font></td>
<td><font color=#F92663>3.160</font></td>
<td><font color=#F92663>111.21%</font></td>
</tr>
<tr>
<td><font color=#F92663>q20</font></td>
<td><font color=#F92663>43.48</font></td>
<td><font color=#F92663>46.49</font></td>
<td><font color=#F92663>3.009</font></td>
<td><font color=#F92663>106.92%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q21</font></td>
<td><font color=#6F9915>384.72</font></td>
<td><font color=#6F9915>378.58</font></td>
<td><font color=#6F9915>-6.144</font></td>
<td><font color=#6F9915>98.40%</font></td>
</tr>
<tr>
<td><font color=#F92663>q22</font></td>
<td><font color=#F92663>15.41</font></td>
<td><font color=#F92663>17.87</font></td>
<td><font color=#F92663>2.463</font></td>
<td><font color=#F92663>115.99%</font></td>
</tr>
<tr>
<td><font color=#F92663>total</font></td>
<td><font color=#F92663>1749.25</font></td>
<td><font color=#F92663>1761.44</font></td>
<td><font color=#F92663>12.193</font></td>
<td><font color=#F92663>100.70%</font></td>
</tr>
</tbody>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-6819][CH] Refactor source from jave iter [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6830:
URL: https://github.com/apache/incubator-gluten/pull/6830#issuecomment-2287821815
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-6819][CH] Refactor source from jave iter [incubator-gluten]
Posted by "exmy (via GitHub)" <gi...@apache.org>.
exmy commented on code in PR #6830:
URL: https://github.com/apache/incubator-gluten/pull/6830#discussion_r1716290728
##########
cpp-ch/local-engine/Storages/SourceFromJavaIter.cpp:
##########
@@ -29,24 +29,59 @@
#include <Common/DebugUtils.h>
#include <Common/Exception.h>
#include <Common/JNIUtils.h>
+#include "Interpreters/castColumn.h"
Review Comment:
nit: <Interpreters/castColumn.h>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-6819][CH] Refactor source from jave iter && make casting happens before materializing [incubator-gluten]
Posted by "taiyang-li (via GitHub)" <gi...@apache.org>.
taiyang-li merged PR #6830:
URL: https://github.com/apache/incubator-gluten/pull/6830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-6819][CH] Refactor source from jave iter [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6830:
URL: https://github.com/apache/incubator-gluten/pull/6830#issuecomment-2287816892
https://github.com/apache/incubator-gluten/issues/6819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-6819][CH] Refactor source from jave iter [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6830:
URL: https://github.com/apache/incubator-gluten/pull/6830#issuecomment-2287817085
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org