You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Till Toenshoff <to...@me.com> on 2014/03/12 14:17:12 UTC
Review Request 19117: Deprecated use of MESOS_NATIVE_LIBRARY for JVM
frameworks
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19117/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos-git
Description
-------
Introduced a new environment variable, MESOS_NATIVE_JAVA_LIBRARY. That
variable still points towards libmesos. Future versions however will
not point to valid JNI bindings.
A typical java-based framework relies on mesos.jar to do the loading
but may use some extra logic in its startup to make sure
MESOS_NATIVE[_JAVA]_LIBRARY is set/valid. That extra-logic should now
be adapted to use the new environment variable instead of the old
one. The old one is now marked as being deprecated for use for JVM
based frameworks.
Note:
This patch does not remove the MESOS_NATIVE_LIRBRAY variable. It is
kept for frameworks that are not JVM based but need to bind to the
self-contained Mesos library. MESOS_NATIVE_LIRBRAY points towards
libmesos.
MESOS_NATIVE_JAVA_LIBRARY however is the new variant to be used for
JVM based frameworks.
Diffs
-----
bin/mesos-slave-flags.sh.in dc73aef
src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in 231d1e2
src/slave/containerizer/containerizer.cpp d0a1023
src/tests/environment.cpp 5c92fcd
Diff: https://reviews.apache.org/r/19117/diff/
Testing
-------
make check
Thanks,
Till Toenshoff
Re: Review Request 19117: Deprecated use of MESOS_NATIVE_LIBRARY for JVM
frameworks
Posted by Till Toenshoff <to...@me.com>.
> On March 12, 2014, 11:31 p.m., Adam B wrote:
> > src/slave/containerizer/containerizer.cpp, line 258
> > <https://reviews.apache.org/r/19117/diff/1/?file=517293#file517293line258>
> >
> > Would you still want to set env["MESOS_NATIVE_LIBRARY"] if os::hasenv("MESOS_NATIVE_JAVA_LIBRARY")?
> > Any reason to have both set?
Those are not mutual exclusive. MESOS_NATIVE_LIBRARY is only deprecated for JVM based use. It can still be used for other frameworks that need a self-contained, JNI-binding-free mesos library.
> On March 12, 2014, 11:31 p.m., Adam B wrote:
> > src/tests/environment.cpp, lines 211-213
> > <https://reviews.apache.org/r/19117/diff/1/?file=517294#file517294line211>
> >
> > Test that the deprecated env-variable still works?
Will leave that undone for now.
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19117/#review37013
-----------------------------------------------------------
On March 13, 2014, 3:34 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19117/
> -----------------------------------------------------------
>
> (Updated March 13, 2014, 3:34 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-855
> https://issues.apache.org/jira/browse/MESOS-855
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Introduced a new environment variable, MESOS_NATIVE_JAVA_LIBRARY. That
> variable still points towards libmesos. For allowing a smooth transition
> away from MESOS_NATIVE_LIBRARY towards MESOS_NATIVE_JAVA_LIBRARY whithin
> JVM based frameworks.
>
> Future versions of MESOS_NATIVE_LIBRARY will not point to valid JNI
> bindings.
>
> A typical java-based framework relies on mesos.jar to do the loading
> but may use some extra logic in its startup to make sure
> MESOS_NATIVE[_JAVA]_LIBRARY is set/valid. That extra-logic should now
> be adapted by the framework developers to use the new environment
> variable instead of the old one.
> MESOS_NATIVE_LIBRARY is now marked as being deprecated for use for JVM
> based frameworks.
>
> Note:
> MESOS_NATIVE_LIRBRAY will not be removed. It is kept for frameworks
> that are not JVM based but need to bind to the self-contained Mesos
> library.
>
>
> Diffs
> -----
>
> bin/mesos-slave-flags.sh.in dc73aef
> src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in 231d1e2
> src/slave/containerizer/containerizer.cpp d0a1023
> src/tests/environment.cpp 5c92fcd
>
> Diff: https://reviews.apache.org/r/19117/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 19117: Deprecated use of MESOS_NATIVE_LIBRARY for JVM
frameworks
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On March 12, 2014, 11:31 p.m., Adam B wrote:
> > src/slave/containerizer/containerizer.cpp, line 258
> > <https://reviews.apache.org/r/19117/diff/1/?file=517293#file517293line258>
> >
> > Would you still want to set env["MESOS_NATIVE_LIBRARY"] if os::hasenv("MESOS_NATIVE_JAVA_LIBRARY")?
> > Any reason to have both set?
>
> Till Toenshoff wrote:
> Those are not mutual exclusive. MESOS_NATIVE_LIBRARY is only deprecated for JVM based use. It can still be used for other frameworks that need a self-contained, JNI-binding-free mesos library.
Yes, let's definitely keep MESOS_NATIVE_LIBRARY.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19117/#review37013
-----------------------------------------------------------
On March 13, 2014, 3:34 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19117/
> -----------------------------------------------------------
>
> (Updated March 13, 2014, 3:34 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-855
> https://issues.apache.org/jira/browse/MESOS-855
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Introduced a new environment variable, MESOS_NATIVE_JAVA_LIBRARY. That
> variable still points towards libmesos. For allowing a smooth transition
> away from MESOS_NATIVE_LIBRARY towards MESOS_NATIVE_JAVA_LIBRARY whithin
> JVM based frameworks.
>
> Future versions of MESOS_NATIVE_LIBRARY will not point to valid JNI
> bindings.
>
> A typical java-based framework relies on mesos.jar to do the loading
> but may use some extra logic in its startup to make sure
> MESOS_NATIVE[_JAVA]_LIBRARY is set/valid. That extra-logic should now
> be adapted by the framework developers to use the new environment
> variable instead of the old one.
> MESOS_NATIVE_LIBRARY is now marked as being deprecated for use for JVM
> based frameworks.
>
> Note:
> MESOS_NATIVE_LIRBRAY will not be removed. It is kept for frameworks
> that are not JVM based but need to bind to the self-contained Mesos
> library.
>
>
> Diffs
> -----
>
> bin/mesos-slave-flags.sh.in dc73aef
> src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in 231d1e2
> src/slave/containerizer/containerizer.cpp d0a1023
> src/tests/environment.cpp 5c92fcd
>
> Diff: https://reviews.apache.org/r/19117/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 19117: Deprecated use of MESOS_NATIVE_LIBRARY for JVM
frameworks
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19117/#review37013
-----------------------------------------------------------
bin/mesos-slave-flags.sh.in
<https://reviews.apache.org/r/19117/#comment68259>
Would you still want to export MESOS_NATIVE_LIBRARY too, until it is fully deprecated?
If not, why are you still defining it above?
src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in
<https://reviews.apache.org/r/19117/#comment68262>
s/"old"/deprecated/
src/slave/containerizer/containerizer.cpp
<https://reviews.apache.org/r/19117/#comment68263>
Would you still want to set env["MESOS_NATIVE_LIBRARY"] if os::hasenv("MESOS_NATIVE_JAVA_LIBRARY")?
Any reason to have both set?
src/tests/environment.cpp
<https://reviews.apache.org/r/19117/#comment68264>
Test that the deprecated env-variable still works?
- Adam B
On March 12, 2014, 8:30 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19117/
> -----------------------------------------------------------
>
> (Updated March 12, 2014, 8:30 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-855
> https://issues.apache.org/jira/browse/MESOS-855
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Introduced a new environment variable, MESOS_NATIVE_JAVA_LIBRARY. That
> variable still points towards libmesos. For allowing a smooth transition
> away from MESOS_NATIVE_LIBRARY towards MESOS_NATIVE_JAVA_LIBRARY whithin
> JVM based frameworks.
>
> Future versions of MESOS_NATIVE_LIBRARY will not point to valid JNI
> bindings.
>
> A typical java-based framework relies on mesos.jar to do the loading
> but may use some extra logic in its startup to make sure
> MESOS_NATIVE[_JAVA]_LIBRARY is set/valid. That extra-logic should now
> be adapted by the framework developers to use the new environment
> variable instead of the old one.
> MESOS_NATIVE_LIBRARY is now marked as being deprecated for use for JVM
> based frameworks.
>
> Note:
> MESOS_NATIVE_LIRBRAY will not be removed. It is kept for frameworks
> that are not JVM based but need to bind to the self-contained Mesos
> library.
>
>
> Diffs
> -----
>
> bin/mesos-slave-flags.sh.in dc73aef
> src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in 231d1e2
> src/slave/containerizer/containerizer.cpp d0a1023
> src/tests/environment.cpp 5c92fcd
>
> Diff: https://reviews.apache.org/r/19117/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 19117: Deprecated use of MESOS_NATIVE_LIBRARY for JVM
frameworks
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19117/#review37029
-----------------------------------------------------------
Patch looks great!
Reviews applied: [19117]
All tests passed.
- Mesos ReviewBot
On March 13, 2014, 3:34 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19117/
> -----------------------------------------------------------
>
> (Updated March 13, 2014, 3:34 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-855
> https://issues.apache.org/jira/browse/MESOS-855
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Introduced a new environment variable, MESOS_NATIVE_JAVA_LIBRARY. That
> variable still points towards libmesos. For allowing a smooth transition
> away from MESOS_NATIVE_LIBRARY towards MESOS_NATIVE_JAVA_LIBRARY whithin
> JVM based frameworks.
>
> Future versions of MESOS_NATIVE_LIBRARY will not point to valid JNI
> bindings.
>
> A typical java-based framework relies on mesos.jar to do the loading
> but may use some extra logic in its startup to make sure
> MESOS_NATIVE[_JAVA]_LIBRARY is set/valid. That extra-logic should now
> be adapted by the framework developers to use the new environment
> variable instead of the old one.
> MESOS_NATIVE_LIBRARY is now marked as being deprecated for use for JVM
> based frameworks.
>
> Note:
> MESOS_NATIVE_LIRBRAY will not be removed. It is kept for frameworks
> that are not JVM based but need to bind to the self-contained Mesos
> library.
>
>
> Diffs
> -----
>
> bin/mesos-slave-flags.sh.in dc73aef
> src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in 231d1e2
> src/slave/containerizer/containerizer.cpp d0a1023
> src/tests/environment.cpp 5c92fcd
>
> Diff: https://reviews.apache.org/r/19117/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 19117: Deprecated use of MESOS_NATIVE_LIBRARY for JVM
frameworks
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19117/#review37436
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 13, 2014, 3:34 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19117/
> -----------------------------------------------------------
>
> (Updated March 13, 2014, 3:34 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-855
> https://issues.apache.org/jira/browse/MESOS-855
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Introduced a new environment variable, MESOS_NATIVE_JAVA_LIBRARY. That
> variable still points towards libmesos. For allowing a smooth transition
> away from MESOS_NATIVE_LIBRARY towards MESOS_NATIVE_JAVA_LIBRARY whithin
> JVM based frameworks.
>
> Future versions of MESOS_NATIVE_LIBRARY will not point to valid JNI
> bindings.
>
> A typical java-based framework relies on mesos.jar to do the loading
> but may use some extra logic in its startup to make sure
> MESOS_NATIVE[_JAVA]_LIBRARY is set/valid. That extra-logic should now
> be adapted by the framework developers to use the new environment
> variable instead of the old one.
> MESOS_NATIVE_LIBRARY is now marked as being deprecated for use for JVM
> based frameworks.
>
> Note:
> MESOS_NATIVE_LIRBRAY will not be removed. It is kept for frameworks
> that are not JVM based but need to bind to the self-contained Mesos
> library.
>
>
> Diffs
> -----
>
> bin/mesos-slave-flags.sh.in dc73aef
> src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in 231d1e2
> src/slave/containerizer/containerizer.cpp d0a1023
> src/tests/environment.cpp 5c92fcd
>
> Diff: https://reviews.apache.org/r/19117/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 19117: Deprecated use of MESOS_NATIVE_LIBRARY for JVM
frameworks
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19117/
-----------------------------------------------------------
(Updated March 13, 2014, 3:34 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Addressed some issues.
Bugs: MESOS-855
https://issues.apache.org/jira/browse/MESOS-855
Repository: mesos-git
Description
-------
Introduced a new environment variable, MESOS_NATIVE_JAVA_LIBRARY. That
variable still points towards libmesos. For allowing a smooth transition
away from MESOS_NATIVE_LIBRARY towards MESOS_NATIVE_JAVA_LIBRARY whithin
JVM based frameworks.
Future versions of MESOS_NATIVE_LIBRARY will not point to valid JNI
bindings.
A typical java-based framework relies on mesos.jar to do the loading
but may use some extra logic in its startup to make sure
MESOS_NATIVE[_JAVA]_LIBRARY is set/valid. That extra-logic should now
be adapted by the framework developers to use the new environment
variable instead of the old one.
MESOS_NATIVE_LIBRARY is now marked as being deprecated for use for JVM
based frameworks.
Note:
MESOS_NATIVE_LIRBRAY will not be removed. It is kept for frameworks
that are not JVM based but need to bind to the self-contained Mesos
library.
Diffs (updated)
-----
bin/mesos-slave-flags.sh.in dc73aef
src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in 231d1e2
src/slave/containerizer/containerizer.cpp d0a1023
src/tests/environment.cpp 5c92fcd
Diff: https://reviews.apache.org/r/19117/diff/
Testing
-------
make check
Thanks,
Till Toenshoff
Re: Review Request 19117: Deprecated use of MESOS_NATIVE_LIBRARY for JVM
frameworks
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19117/#review36927
-----------------------------------------------------------
Patch looks great!
Reviews applied: [19117]
All tests passed.
- Mesos ReviewBot
On March 12, 2014, 3:30 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19117/
> -----------------------------------------------------------
>
> (Updated March 12, 2014, 3:30 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-855
> https://issues.apache.org/jira/browse/MESOS-855
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Introduced a new environment variable, MESOS_NATIVE_JAVA_LIBRARY. That
> variable still points towards libmesos. For allowing a smooth transition
> away from MESOS_NATIVE_LIBRARY towards MESOS_NATIVE_JAVA_LIBRARY whithin
> JVM based frameworks.
>
> Future versions of MESOS_NATIVE_LIBRARY will not point to valid JNI
> bindings.
>
> A typical java-based framework relies on mesos.jar to do the loading
> but may use some extra logic in its startup to make sure
> MESOS_NATIVE[_JAVA]_LIBRARY is set/valid. That extra-logic should now
> be adapted by the framework developers to use the new environment
> variable instead of the old one.
> MESOS_NATIVE_LIBRARY is now marked as being deprecated for use for JVM
> based frameworks.
>
> Note:
> MESOS_NATIVE_LIRBRAY will not be removed. It is kept for frameworks
> that are not JVM based but need to bind to the self-contained Mesos
> library.
>
>
> Diffs
> -----
>
> bin/mesos-slave-flags.sh.in dc73aef
> src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in 231d1e2
> src/slave/containerizer/containerizer.cpp d0a1023
> src/tests/environment.cpp 5c92fcd
>
> Diff: https://reviews.apache.org/r/19117/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 19117: Deprecated use of MESOS_NATIVE_LIBRARY for JVM
frameworks
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19117/
-----------------------------------------------------------
(Updated March 12, 2014, 3:30 p.m.)
Review request for mesos and Vinod Kone.
Bugs: MESOS-855
https://issues.apache.org/jira/browse/MESOS-855
Repository: mesos-git
Description (updated)
-------
Introduced a new environment variable, MESOS_NATIVE_JAVA_LIBRARY. That
variable still points towards libmesos. For allowing a smooth transition
away from MESOS_NATIVE_LIBRARY towards MESOS_NATIVE_JAVA_LIBRARY whithin
JVM based frameworks.
Future versions of MESOS_NATIVE_LIBRARY will not point to valid JNI
bindings.
A typical java-based framework relies on mesos.jar to do the loading
but may use some extra logic in its startup to make sure
MESOS_NATIVE[_JAVA]_LIBRARY is set/valid. That extra-logic should now
be adapted by the framework developers to use the new environment
variable instead of the old one.
MESOS_NATIVE_LIBRARY is now marked as being deprecated for use for JVM
based frameworks.
Note:
MESOS_NATIVE_LIRBRAY will not be removed. It is kept for frameworks
that are not JVM based but need to bind to the self-contained Mesos
library.
Diffs
-----
bin/mesos-slave-flags.sh.in dc73aef
src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in 231d1e2
src/slave/containerizer/containerizer.cpp d0a1023
src/tests/environment.cpp 5c92fcd
Diff: https://reviews.apache.org/r/19117/diff/
Testing
-------
make check
Thanks,
Till Toenshoff
Re: Review Request 19117: Deprecated use of MESOS_NATIVE_LIBRARY for JVM
frameworks
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19117/
-----------------------------------------------------------
(Updated March 12, 2014, 3:22 p.m.)
Review request for mesos and Vinod Kone.
Repository: mesos-git
Description
-------
Introduced a new environment variable, MESOS_NATIVE_JAVA_LIBRARY. That
variable still points towards libmesos. Future versions however will
not point to valid JNI bindings.
A typical java-based framework relies on mesos.jar to do the loading
but may use some extra logic in its startup to make sure
MESOS_NATIVE[_JAVA]_LIBRARY is set/valid. That extra-logic should now
be adapted to use the new environment variable instead of the old
one. The old one is now marked as being deprecated for use for JVM
based frameworks.
Note:
This patch does not remove the MESOS_NATIVE_LIRBRAY variable. It is
kept for frameworks that are not JVM based but need to bind to the
self-contained Mesos library. MESOS_NATIVE_LIRBRAY points towards
libmesos.
MESOS_NATIVE_JAVA_LIBRARY however is the new variant to be used for
JVM based frameworks.
Diffs
-----
bin/mesos-slave-flags.sh.in dc73aef
src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in 231d1e2
src/slave/containerizer/containerizer.cpp d0a1023
src/tests/environment.cpp 5c92fcd
Diff: https://reviews.apache.org/r/19117/diff/
Testing
-------
make check
Thanks,
Till Toenshoff