You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2019/11/08 15:05:51 UTC
[GitHub] [httpcomponents-core] michael-o commented on a change in pull
request #159: Development
michael-o commented on a change in pull request #159: Development
URL: https://github.com/apache/httpcomponents-core/pull/159#discussion_r344216706
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/reactor/IOReactorConfig.java
##########
@@ -205,31 +205,31 @@ public static Builder copy(final IOReactorConfig config) {
public static class Builder {
- private static int DefaultMaxIoThreadCount = -1;
+ private static int DEF_MAX_IO_THREAD_COUNT = -1;
/**
* Gets the default value for {@code ioThreadCount}. Returns
* {@link Runtime#availableProcessors()} if
- * {@link #setDefaultMaxIoThreadCount(int)} was called with a value less <= 0.
+ * {@link #setDefaultMaxIOThreadCount(int)} was called with a value less <= 0.
*
* @return the default value for ioThreadCount.
* @since 4.4.10
*/
- public static int getDefaultMaxIoThreadCount() {
- return DefaultMaxIoThreadCount > 0 ? DefaultMaxIoThreadCount : Runtime.getRuntime().availableProcessors();
+ public static int getDefaultMaxIOThreadCount() {
+ return DEF_MAX_IO_THREAD_COUNT > 0 ? DEF_MAX_IO_THREAD_COUNT : Runtime.getRuntime().availableProcessors();
}
/**
* Sets the default value for {@code ioThreadCount}. Use a value <= 0 to
- * cause {@link #getDefaultMaxIoThreadCount()} to return
+ * cause {@link #getDefaultMaxIOThreadCount()} to return
* {@link Runtime#availableProcessors()}.
*
* @param defaultMaxIoThreadCount
* the default value for ioThreadCount.
* @since 4.4.10
*/
- public static void setDefaultMaxIoThreadCount(final int defaultMaxIoThreadCount) {
- DefaultMaxIoThreadCount = defaultMaxIoThreadCount;
+ public static void setDefaultMaxIOThreadCount(final int defaultMaxIoThreadCount) {
Review comment:
The arg should read `defaultMaxIOThreadCount`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org