[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #10451: ARROW-12966: [Python] Expose element_wise_min/max and options in Python

[GitBox <gi...@apache.org>]

jorisvandenbossche commented on a change in pull request #10451:
URL: https://github.com/apache/arrow/pull/10451#discussion_r645573085



##########
File path: cpp/src/arrow/compute/api_scalar.h
##########
@@ -266,9 +267,10 @@ Result<Datum> Power(const Datum& left, const Datum& right,
 /// \param[in] ctx the function execution context, optional
 /// \return the element-wise maximum
 ARROW_EXPORT
-Result<Datum> ElementWiseMax(const std::vector<Datum>& args,
-                             ElementWiseAggregateOptions options = {},
-                             ExecContext* ctx = NULLPTR);
+Result<Datum> ElementWiseMax(
+    const std::vector<Datum>& args,
+    ElementWiseAggregateOptions options = ElementWiseAggregateOptions::Defaults(),

Review comment:
       This change to use the `::Defaults()` pattern is not necessarily needed (I was copying it from the aggregate kernels, but the scalar kernels don't do this), so I can revert this part.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org