You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by kishorvpatil <gi...@git.apache.org> on 2017/10/09 15:21:47 UTC

[GitHub] storm pull request #2345: STORM-2438: added in rebalance changes to support ...

Github user kishorvpatil commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2345#discussion_r143499778
  
    --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/Slot.java ---
    @@ -104,9 +111,12 @@
                 this.port = port;
                 this.iSupervisor = iSupervisor;
                 this.localState = localState;
    +            this.changingCallback = changingCallback;
             }
         }
    -    
    +
    +    //TODO go through all of the state transitions and make sure we handle changingBlobs
    +    //TODO make sure to add in transition helpers that clean changingBlobs && pendingChangeingBlobs for not the current topology
    --- End diff --
    
    ??


---