[GitHub] [doris] morningman commented on a diff in pull request #10645: [FIX] bottom line solution for vec outer join

[GitBox <gi...@apache.org>]

morningman commented on code in PR #10645:
URL: https://github.com/apache/doris/pull/10645#discussion_r914895847


##########
gensrc/thrift/PlanNodes.thrift:
##########
@@ -465,6 +465,8 @@ struct TAggregationNode {
   5: required bool need_finalize
   6: optional bool use_streaming_preaggregation
   7: optional bool is_update_stage
+
+  8: required list<bool> aggregate_function_changed_flags

Review Comment:
   use optional, and add some comments



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org