[GitHub] [doris] wangbo commented on a diff in pull request #11175: [improvement]Use phmap for aggregation with integer keys

[GitBox <gi...@apache.org>]

wangbo commented on code in PR #11175:
URL: https://github.com/apache/doris/pull/11175#discussion_r928739166


##########
be/src/vec/exec/vaggregation_node.h:
##########
@@ -157,7 +157,7 @@ struct AggregationMethodStringNoCache {
 
 /// For the case where there is one numeric key.
 /// FieldType is UInt8/16/32/64 for any type with corresponding bit width.
-template <typename FieldType, typename TData, bool consecutive_keys_optimization = true>
+template <typename FieldType, typename TData, bool consecutive_keys_optimization = false>

Review Comment:
   Why set consecutive_keys_optimization = false here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org