[jira] Commented: (WINK-175) Change ProvidersRegistry MediaTypeMap to allow gets to be faster

["Michael Elman (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WINK-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753437#action_12753437 ] 

Michael Elman commented on WINK-175:
------------------------------------

If I remember correctly SimpleConcurrentMap doesn't make any cache/soft/weak/references. It simply wraps the provided map with ReentrantReadWriteLock.
It's SoftConcurrentMap that wraps WeakHashMap.

Does Doug Larson makes multi-threaded tests?
SimpleConcurrentMap should have a better performance for multiple threads, since it locks get with a read lock, which allows multiple threads to read from a map simultaneously.

> Change ProvidersRegistry MediaTypeMap to allow gets to be faster
> ----------------------------------------------------------------
>
>                 Key: WINK-175
>                 URL: https://issues.apache.org/jira/browse/WINK-175
>             Project: Wink
>          Issue Type: Improvement
>          Components: Common
>    Affects Versions: 0.2
>            Reporter: Bryant Luk
>             Fix For: 0.2
>
>
> Doug Larson did some more profiling and pointed out that on the ProvidersRegistry MediaTypeMap, using a ConcurrentHashMap over SimpleConcurrentMap actually improves performance by a few percentage points.
> {code}
>         private final SimpleMap<Class<?>, SoftReference<SimpleMap<MediaType, List<ObjectFactory<T>>>>> providersCache =
>                                                                                                                           new SimpleConcurrentMap<Class<?>, SoftReference<SimpleMap<MediaType, List<ObjectFactory<T>>>>>(); ;
> {code}
> While the cache keys (Class<?>) would not be WeakReferences, the values would still be SoftReferences.
> Thoughts?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.