[GitHub] [superset] nytai commented on a diff in pull request #23416: feat(helm): add nodeselector and tolerations to init job

["nytai (via GitHub)" <gi...@apache.org>]

nytai commented on code in PR #23416:
URL: https://github.com/apache/superset/pull/23416#discussion_r1141558591


##########
helm/superset/templates/init-job.yaml:
##########
@@ -83,6 +83,18 @@ spec:
         command: {{  tpl (toJson .Values.init.command) . }}
         resources:
           {{- toYaml .Values.init.resources | nindent 10 }}
+    {{- with .Values.init.nodeSelector }}

Review Comment:
   The current values for these apply to all deployments, do we really need one specific for the init job? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org