[GitHub] [activemq-artemis] clebertsuconic commented on pull request #4509: ARTEMIS-4314 support queue federation batchOnEmpty via consumerWindow…

["clebertsuconic (via GitHub)" <gi...@apache.org>]

clebertsuconic commented on PR #4509:
URL: https://github.com/apache/activemq-artemis/pull/4509#issuecomment-1593720505

   @gtully for some reason I am not being able to make a PR to your repo. Github is not recognizing your user on the filters and giving me a hard time.
   
   So, I created a branch you can pull the commit:
   
   https://github.com/clebertsuconic/activemq-artemis/tree/_4314
   
   
   Basically you will endup in this calling flowControl method. which needs to be protected and using the same thread used to deliver. it's not just that state.. any call to flowControl has to be done through the same thread used to deliver... otherwise you will have races on the number of credits.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org