[jira] [Commented] (ZOOKEEPER-1423) 4lw and jmx should expose the size of the datadir/datalogdir

["Rakesh R (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951111#comment-13951111 ] 

Rakesh R commented on ZOOKEEPER-1423:
-------------------------------------

Thanks Edward for the patch, lgtm mostly. I've few comments, please see:

# Format issues, please correct
{code}
+	public long getDataDirSize();
+        public long getLogDirSize();
{code}
{code}
+
+    public long getDataDirSize() {
+	return provider.getDataDirSize();
+    }
+
+    public long getLogDirSize() {
+	return provider.getLogDirSize();
+    }
{code}
# Can we print the o/p in a single line like:
{code}
"datadir: " + dir + "size: " + dataSize
"logdir: " + dir + "size: " + logSize
{code}
# Small correction,
{code}
the total size of data and log (snapshot) directories' content in bytes.
{code}
Actually it should be snapshot and log, can we rephrase like:
{code}
the total size of snapshot and log files in bytes
{code}
# I feel, its good to expose the dirs path in MBean too.
# please provide javadocs for #getDataDirSize() and #getLogDirSize()

> 4lw and jmx should expose the size of the datadir/datalogdir
> ------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1423
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1423
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: jmx
>    Affects Versions: 3.5.0
>            Reporter: Patrick Hunt
>            Assignee: Edward Ribeiro
>              Labels: newbie
>         Attachments: ZOOKEEPER-1423.2.patch, ZOOKEEPER-1423.3.patch, ZOOKEEPER-1423.patch
>
>
> There are no metrics currently available on the size of the datadir/datalogdir. These grow w/o bound unless the cleanup script is run. It would be good to expose these metrics through jmx/4lw such that monitoring can be done on the size. Would key ppl in on whether cleanup was actually running. In particular this could be monitored/alerted on by third party systems (nagios, ganglia and the like).



--
This message was sent by Atlassian JIRA
(v6.2#6252)