You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by JoshRosen <gi...@git.apache.org> on 2014/12/05 03:59:54 UTC

[GitHub] spark pull request: SPARK-3926 [CORE] Reopened: result of JavaRDD ...

Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3587#discussion_r21352968
  
    --- Diff: core/src/main/scala/org/apache/spark/api/java/JavaUtils.scala ---
    @@ -32,7 +33,65 @@ private[spark] object JavaUtils {
       def mapAsSerializableJavaMap[A, B](underlying: collection.Map[A, B]) =
         new SerializableMapWrapper(underlying)
     
    +  // Implementation is copied from scala.collection.convert.Wrappers.MapWrapper,
    --- End diff --
    
    Does this create any licensing issues?  Do we need to add a separate header somewhere?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org