You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Michael Osipov (JIRA)" <ji...@apache.org> on 2015/02/11 12:01:11 UTC

[jira] [Comment Edited] (HTTPCORE-395) VersionInfo#getUserAgent reports incorrect Java version

    [ https://issues.apache.org/jira/browse/HTTPCORE-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14316030#comment-14316030 ] 

Michael Osipov edited comment on HTTPCORE-395 at 2/11/15 11:00 AM:
-------------------------------------------------------------------

OK, so would it be fine to leave that as-is in 4.4.x and trim that in 5.0?


was (Author: michael-o):
OK, so would it be fine to lease that as-is in 4.4.x and trim that in 5.0?

> VersionInfo#getUserAgent reports incorrect Java version
> -------------------------------------------------------
>
>                 Key: HTTPCORE-395
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-395
>             Project: HttpComponents HttpCore
>          Issue Type: Bug
>          Components: HttpCore
>    Affects Versions: 4.4
>            Reporter: Michael Osipov
>            Assignee: Michael Osipov
>             Fix For: 4.4.1, 5.0-alpha1
>
>
> Currently {{VersionInfo#getUserAgent}} sets {{Java 1.5 minimum}} by default but both [HttpCore|http://hc.apache.org/httpcomponents-core-4.4.x/httpcore/project-summary.html] and [HttpClient|http://hc.apache.org/httpcomponents-client-4.4.x/httpclient/project-summary.html] have Java 1.6 now. Values are completely ignored.
> This needs to be determined at runtime. The best approach would be add a manifest property {{X-Compile-Target-JDK}} just like {{[commons-parent|http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?view=markup#l506]}} does. {{VersionInfo}} can be changed and report that information.
> Alternatively, this information can be completely dropped.
> The output now is
> {noformat}
> [http-8081-1] DEBUG org.apache.http.wire - http-outgoing-44 >> "User-Agent: Apache-HttpClient/4.4 (Java 1.5 minimum; Java/1.7.0_55)[\r][\n]"
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org