You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/23 06:49:47 UTC
[GitHub] [spark] cloud-fan opened a new pull request #29200: [SPARK-32251][SQL][TESTS] improve SQL keyword test
cloud-fan opened a new pull request #29200:
URL: https://github.com/apache/spark/pull/29200
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Improve the `SQLKeywordSuite` so that:
1. it checks keywords under default mode as well
2. it checks if there are typos in the doc (found one and fixed in this PR)
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
better test coverage
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
N/A
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29200: [SPARK-32251][SQL][TESTS][FOLLOWUP] improve SQL keyword test
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #29200:
URL: https://github.com/apache/spark/pull/29200#discussion_r459253430
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/SQLKeywordSuite.scala
##########
@@ -146,11 +159,32 @@ class SQLKeywordSuite extends SparkFunSuite with SQLKeywordUtils {
}
}
- test("Spark keywords are documented correctly") {
- val reservedKeywordsInDoc = keywordsInDoc.filter(_.apply(1) == "reserved").map(_.head).toSet
- if (reservedKeywordsInAnsiMode != reservedKeywordsInDoc) {
- val misImplemented = (reservedKeywordsInDoc -- reservedKeywordsInAnsiMode).toSeq.sorted
- fail("Some keywords are documented as reserved but actually not: " +
+ test("Spark keywords are documented correctly under ansi mode") {
+ // keywords under ANSI mode should either be reserved or non-reserved.
+ keywordsInDoc.map(_.apply(1)).foreach { desc =>
+ assert(desc == "reserved" || desc == "non-reserved")
+ }
+
+ val nonReservedInDoc = keywordsInDoc.filter(_.apply(1) == "non-reserved").map(_.head).toSet
+ if (nonReservedKeywordsInAnsiMode != nonReservedInDoc) {
+ val misImplemented = ((nonReservedInDoc -- nonReservedKeywordsInAnsiMode) ++
+ (nonReservedKeywordsInAnsiMode -- nonReservedInDoc)).toSeq.sorted
+ fail("Some keywords are documented and implemented inconsistently: " +
+ misImplemented.mkString(", "))
+ }
+ }
+
+ test("Spark keywords are documented correctly under default mode") {
Review comment:
Oh, looks nice!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29200: [SPARK-32251][SQL][TESTS][FOLLOWUP] improve SQL keyword test
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29200:
URL: https://github.com/apache/spark/pull/29200#issuecomment-662851355
**[Test build #126391 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126391/testReport)** for PR 29200 at commit [`28b635b`](https://github.com/apache/spark/commit/28b635b9a3c461e8ffd594b6bc2eb7b941fcf912).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29200: [SPARK-32251][SQL][TESTS][FOLLOWUP] improve SQL keyword test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29200:
URL: https://github.com/apache/spark/pull/29200#issuecomment-662971998
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29200: [SPARK-32251][SQL][TESTS][FOLLOWUP] improve SQL keyword test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29200:
URL: https://github.com/apache/spark/pull/29200#issuecomment-662851355
**[Test build #126391 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126391/testReport)** for PR 29200 at commit [`28b635b`](https://github.com/apache/spark/commit/28b635b9a3c461e8ffd594b6bc2eb7b941fcf912).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29200: [SPARK-32251][SQL][TESTS][FOLLOWUP] improve SQL keyword test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29200:
URL: https://github.com/apache/spark/pull/29200#issuecomment-662848235
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29200: [SPARK-32251][SQL][TESTS][FOLLOWUP] improve SQL keyword test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29200:
URL: https://github.com/apache/spark/pull/29200#issuecomment-662971343
**[Test build #126391 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126391/testReport)** for PR 29200 at commit [`28b635b`](https://github.com/apache/spark/commit/28b635b9a3c461e8ffd594b6bc2eb7b941fcf912).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29200: [SPARK-32251][SQL][TESTS][FOLLOWUP] improve SQL keyword test
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #29200:
URL: https://github.com/apache/spark/pull/29200#discussion_r459253769
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/SQLKeywordSuite.scala
##########
@@ -146,11 +159,32 @@ class SQLKeywordSuite extends SparkFunSuite with SQLKeywordUtils {
}
}
- test("Spark keywords are documented correctly") {
- val reservedKeywordsInDoc = keywordsInDoc.filter(_.apply(1) == "reserved").map(_.head).toSet
- if (reservedKeywordsInAnsiMode != reservedKeywordsInDoc) {
- val misImplemented = (reservedKeywordsInDoc -- reservedKeywordsInAnsiMode).toSeq.sorted
- fail("Some keywords are documented as reserved but actually not: " +
+ test("Spark keywords are documented correctly under ansi mode") {
Review comment:
nit: `ansi` -> `ANSI`; the uppercase looks better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #29200: [SPARK-32251][SQL][TESTS][FOLLOWUP] improve SQL keyword test
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #29200:
URL: https://github.com/apache/spark/pull/29200#issuecomment-663025280
the last commit just update test name, merging to master/3.0, thanks for the review!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29200: [SPARK-32251][SQL][TESTS][FOLLOWUP] improve SQL keyword test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29200:
URL: https://github.com/apache/spark/pull/29200#issuecomment-662848235
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #29200: [SPARK-32251][SQL][TESTS] improve SQL keyword test
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #29200:
URL: https://github.com/apache/spark/pull/29200#issuecomment-662846486
cc @maropu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29200: [SPARK-32251][SQL][TESTS][FOLLOWUP] improve SQL keyword test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29200:
URL: https://github.com/apache/spark/pull/29200#issuecomment-662971998
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #29200: [SPARK-32251][SQL][TESTS][FOLLOWUP] improve SQL keyword test
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #29200:
URL: https://github.com/apache/spark/pull/29200
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org