You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/12/07 16:18:10 UTC

[jira] [Commented] (METAMODEL-218) Mapping of STRING and NUMBER data types in JDBC module's CREATE TABLE support not working

    [ https://issues.apache.org/jira/browse/METAMODEL-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15045066#comment-15045066 ] 

ASF GitHub Bot commented on METAMODEL-218:
------------------------------------------

GitHub user kaspersorensen opened a pull request:

    https://github.com/apache/metamodel/pull/76

    METAMODEL-218: Fixed

    This fixes METAMODEL-218 by adding a few return statement in DefaultQueryRewriter.
    
    Also updated the test template to ensure that it's working on all the databases covered by these tests.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kaspersorensen/metamodel METAMODEL-218

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metamodel/pull/76.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #76
    
----
commit 1a2a45a866b83805fd78d06281fa969b06b2d7a0
Author: Kasper Sørensen <i....@gmail.com>
Date:   2015-12-07T15:16:39Z

    METAMODEL-218: Fixed

----


> Mapping of STRING and NUMBER data types in JDBC module's CREATE TABLE support not working
> -----------------------------------------------------------------------------------------
>
>                 Key: METAMODEL-218
>                 URL: https://issues.apache.org/jira/browse/METAMODEL-218
>             Project: Apache MetaModel
>          Issue Type: Bug
>    Affects Versions: 4.4.1
>            Reporter: Kasper Sørensen
>            Assignee: Kasper Sørensen
>
> It seems that the work we did in METAMODEL-141 had a few omissions. Specifically the NUMBER and STRING data type support in the JDBC module isn't correctly being applied.
> The issue seems to be a missing return statement(!) ...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)