[GitHub] [spark] HyukjinKwon commented on a change in pull request #34356: [SPARK-36554][PYTHON] Expose make_date expression in functions.scala

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #34356:
URL: https://github.com/apache/spark/pull/34356#discussion_r734145351



##########
File path: python/pyspark/sql/functions.py
##########
@@ -2131,6 +2131,21 @@ def weekofyear(col: "ColumnOrName") -> Column:
     return Column(sc._jvm.functions.weekofyear(_to_java_column(col)))
 
 
+def make_date(year: Column, month: Column, day: Column) -> Column:

Review comment:
       should be `ColumnOrName` instead of `Column`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org