You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@plc4x.apache.org by jf...@apache.org on 2018/11/24 19:51:23 UTC
[incubator-plc4x] 06/06: [plc4j-opm] Minor test coverage.
This is an automated email from the ASF dual-hosted git repository.
jfeinauer pushed a commit to branch feature/plc4j-scraper
in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git
commit 258af1adcb7523cf83f9e8b08c0f9a0b4e4007df
Author: Julian Feinauer <j....@pragmaticminds.de>
AuthorDate: Sat Nov 24 20:47:32 2018 +0100
[plc4j-opm] Minor test coverage.
---
.../org/apache/plc4x/java/opm/PlcEntityInterceptor.java | 1 +
.../apache/plc4x/java/opm/PlcEntityInterceptorTest.java | 15 +++++++++++++++
2 files changed, 16 insertions(+)
diff --git a/plc4j/utils/opm/src/main/java/org/apache/plc4x/java/opm/PlcEntityInterceptor.java b/plc4j/utils/opm/src/main/java/org/apache/plc4x/java/opm/PlcEntityInterceptor.java
index ea0bb2e..26f121c 100644
--- a/plc4j/utils/opm/src/main/java/org/apache/plc4x/java/opm/PlcEntityInterceptor.java
+++ b/plc4j/utils/opm/src/main/java/org/apache/plc4x/java/opm/PlcEntityInterceptor.java
@@ -60,6 +60,7 @@ import java.util.concurrent.TimeoutException;
*
* @author julian
*/
+@SuppressWarnings({"common-java:DuplicatedBlocks", "Duplicates"})
public class PlcEntityInterceptor {
private static final Logger LOGGER = LoggerFactory.getLogger(PlcEntityInterceptor.class);
diff --git a/plc4j/utils/opm/src/test/java/org/apache/plc4x/java/opm/PlcEntityInterceptorTest.java b/plc4j/utils/opm/src/test/java/org/apache/plc4x/java/opm/PlcEntityInterceptorTest.java
index 0873b13..6854123 100644
--- a/plc4j/utils/opm/src/test/java/org/apache/plc4x/java/opm/PlcEntityInterceptorTest.java
+++ b/plc4j/utils/opm/src/test/java/org/apache/plc4x/java/opm/PlcEntityInterceptorTest.java
@@ -139,7 +139,12 @@ public class PlcEntityInterceptorTest implements WithAssertions {
}
public void setOk2(String ok) {
+ }
+
+ public void setOkOk(String ok, String ok2) {
+ }
+ public void someNotSetterMethod(String arg) {
}
public void something() {
@@ -170,6 +175,16 @@ public class PlcEntityInterceptorTest implements WithAssertions {
.isInstanceOf(OPMException.class)
.hasMessage("Problem during processing")
.hasStackTraceContaining(" Unable to read specified field 'org.apache.plc4x.java.opm.PlcEntityInterceptorTest$Misc$MiscEntity.ok2', response code was 'null'");
+ assertThatThrownBy(() -> PlcEntityInterceptor.interceptSetter(null, MiscEntity.class.getDeclaredMethod("setOk2", String.class), callable, null, plcDriverManager, null, lastFetched, lastWritten))
+ .isInstanceOf(OPMException.class)
+ .hasMessage("Problem during processing")
+ .hasStackTraceContaining(" Unable to read specified field 'org.apache.plc4x.java.opm.PlcEntityInterceptorTest$Misc$MiscEntity.ok2', response code was 'null'");
+ assertThatThrownBy(() -> PlcEntityInterceptor.interceptSetter(null, MiscEntity.class.getDeclaredMethod("setOkOk", String.class, String.class), callable, null, plcDriverManager, null, lastFetched, lastWritten))
+ .isInstanceOf(OPMException.class)
+ .hasMessage("Only setter with one arguments are supported");
+ assertThatThrownBy(() -> PlcEntityInterceptor.interceptSetter(null, MiscEntity.class.getDeclaredMethod("someNotSetterMethod", String.class), callable, null, plcDriverManager, null, lastFetched, lastWritten))
+ .isInstanceOf(OPMException.class)
+ .hasMessage("Unable to forward invocation someNotSetterMethod on connected PlcEntity");
}
}