[GitHub] csantanapr commented on a change in pull request #86: Do not hard code API host of push notification service

[GitBox <gi...@apache.org>]

csantanapr commented on a change in pull request #86: Do not hard code API host of push notification service
URL: https://github.com/apache/incubator-openwhisk-package-pushnotifications/pull/86#discussion_r166799653
 
 

 ##########
 File path: packages/actions/sendMessage.js
 ##########
 @@ -426,10 +427,22 @@ function main(params) {
 
   var bodyData = JSON.stringify(sendMessage);
   var request = require('request');
+  var apiHost;
+  if (params.apiHost) {
+    apiHost = params.apiHost;
+  }
+  else if (params.admin_url) {
+    var adminURL = require('url').parse(`https:${params.admin_url}`);
 
 Review comment:
   Need to check if admin url starts with http first
   Today it starts with // but in future might be corrected with https:// 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services