You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/10 17:07:32 UTC
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4229:
Move process text and quote character from segment details to IdentifierValue
codecov-io commented on issue #4229: Move process text and quote character from segment details to IdentifierValue
URL: https://github.com/apache/incubator-shardingsphere/pull/4229#issuecomment-584228152
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229?src=pr&el=h1) Report
> Merging [#4229](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/ecf08f90f690d3e284001e8305aa864481d66c3f?src=pr&el=desc) will **increase** coverage by `0.22%`.
> The diff coverage is `2.85%`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4229 +/- ##
===========================================
+ Coverage 60.57% 60.8% +0.22%
Complexity 352 352
===========================================
Files 1015 1012 -3
Lines 17000 17025 +25
Branches 3001 3004 +3
===========================================
+ Hits 10298 10352 +54
+ Misses 6050 6020 -30
- Partials 652 653 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...e/sql/parser/sql/segment/generic/TableSegment.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9nZW5lcmljL1RhYmxlU2VnbWVudC5qYXZh) | `28.57% <ø> (-32.97%)` | `1 <0> (ø)` | |
| [...l/parser/sql/segment/dml/column/ColumnSegment.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9kbWwvY29sdW1uL0NvbHVtblNlZ21lbnQuamF2YQ==) | `50% <ø> (-37.5%)` | `0 <0> (ø)` | |
| [...re/extractor/impl/common/index/IndexExtractor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL2V4dHJhY3Rvci9pbXBsL2NvbW1vbi9pbmRleC9JbmRleEV4dHJhY3Rvci5qYXZh) | `16.66% <0%> (-8.34%)` | `1 <0> (ø)` | |
| [...select/item/impl/ShorthandProjectionExtractor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL2V4dHJhY3Rvci9pbXBsL2RtbC9zZWxlY3QvaXRlbS9pbXBsL1Nob3J0aGFuZFByb2plY3Rpb25FeHRyYWN0b3IuamF2YQ==) | `7.14% <0%> (-0.55%)` | `1 <0> (ø)` | |
| [...re/extractor/impl/common/table/TableExtractor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL2V4dHJhY3Rvci9pbXBsL2NvbW1vbi90YWJsZS9UYWJsZUV4dHJhY3Rvci5qYXZh) | `5.26% <0%> (-0.62%)` | `1 <0> (ø)` | |
| [...l/parser/sql/value/identifier/IdentifierValue.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvdmFsdWUvaWRlbnRpZmllci9JZGVudGlmaWVyVmFsdWUuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...apache/shardingsphere/sql/parser/MySQLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL015U1FMVmlzaXRvci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../sql/segment/dml/item/ColumnProjectionSegment.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9kbWwvaXRlbS9Db2x1bW5Qcm9qZWN0aW9uU2VnbWVudC5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../extractor/impl/common/column/ColumnExtractor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL2V4dHJhY3Rvci9pbXBsL2NvbW1vbi9jb2x1bW4vQ29sdW1uRXh0cmFjdG9yLmphdmE=) | `9.09% <0%> (-2.03%)` | `1 <0> (ø)` | |
| [...dingsphere/sql/parser/visitor/MySQLDALVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvTXlTUUxEQUxWaXNpdG9yLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| ... and [71 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229?src=pr&el=footer). Last update [ecf08f9...e2b7c15](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services