You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/12/06 19:40:19 UTC
Review Request 64389: Used a wrapper message for storage resource
provider info.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64389/
-----------------------------------------------------------
Review request for mesos, Chun-Hung Hsiao and Joseph Wu.
Repository: mesos
Description
-------
This is more future proof in case we want to add more storage resource
provider specific information.
Diffs
-----
include/mesos/mesos.proto 5b93478ed1a8250b05c44ec8b4d1f660a2053b87
include/mesos/v1/mesos.proto 22b3c6889d975147b001ef145ba4fc382debf70a
src/common/type_utils.cpp 1b466fcfd133b6fd0067668c7ba54d1ce80c8702
src/resource_provider/storage/provider.cpp d35b0d02992e3730ca47906b34c21e1ba9c653e7
src/v1/mesos.cpp 2c81b37468dc27da863eb8a56a213436b94b73de
Diff: https://reviews.apache.org/r/64389/diff/1/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 64389: Used a wrapper message for storage resource
provider info.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64389/#review193034
-----------------------------------------------------------
Ship it!
Ship It!
- Chun-Hung Hsiao
On Dec. 6, 2017, 7:40 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64389/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2017, 7:40 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is more future proof in case we want to add more storage resource
> provider specific information.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5b93478ed1a8250b05c44ec8b4d1f660a2053b87
> include/mesos/v1/mesos.proto 22b3c6889d975147b001ef145ba4fc382debf70a
> src/common/type_utils.cpp 1b466fcfd133b6fd0067668c7ba54d1ce80c8702
> src/resource_provider/storage/provider.cpp d35b0d02992e3730ca47906b34c21e1ba9c653e7
> src/v1/mesos.cpp 2c81b37468dc27da863eb8a56a213436b94b73de
>
>
> Diff: https://reviews.apache.org/r/64389/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>