You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@rocketmq.apache.org by "socutes (via GitHub)" <gi...@apache.org> on 2023/02/18 03:03:34 UTC

[GitHub] [rocketmq] socutes opened a new issue, #6106: Optimize getQueueIdByBroker naming ambiguity

socutes opened a new issue, #6106:
URL: https://github.com/apache/rocketmq/issues/6106

   In org.apache.rocketmq.remoting.protocol.route.QueueData， readQueueNums and writeQueueNums serve different purposes.
   
   In TopicPublishInfo, use getQueueIdByBroker to get the writeQueueNums.command ambiguity affects subsequent code reuse and logic understanding.
   
   It is recommended that getQueueIdByBroker be optimized to getWriteQueueIdByBroker.
   
   <img width="696" alt="image" src="https://user-images.githubusercontent.com/7479320/219828453-bfd82974-7cd6-4f65-b29f-ea83883c81d0.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] zhouxinyu closed issue #6106: Optimize getQueueIdByBroker naming ambiguity

Posted by "zhouxinyu (via GitHub)" <gi...@apache.org>.

zhouxinyu closed issue #6106: Optimize getQueueIdByBroker naming ambiguity
URL: https://github.com/apache/rocketmq/issues/6106


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org